spice-labs-inc / goatrodeo

Apache License 2.0
1 stars 2 forks source link

Moved the `file_size` field from `Item` to `ItemMetaData` #22

Closed dpp closed 1 month ago

dpp commented 1 month ago

💻 Description of Change(s) (w/ context)

Moved the file_size field from Item to ItemMetaData

🧠 Rationale Behind Change(s)

The Item record is supposed to be the enveloped that describes the relationships among graph items and the ItemMetaData field is supposed to be the field that contains the data (e.g., file names, file size, etc.) about the record

📝 Test Plan

Tested that the code works correctly with the generic_metadata branch of Big Tent

📜 Documentation

No documentation as the move was simple

💣 Quality Control

(All items must be checked before a PR is merged) Did you…

Before Merging…

earldouglas commented 1 month ago

The build is failing, but I don't think it's due to anything on our side:

Run sbt test
/home/runner/work/_temp/644f807c-38a6-4265-b367-79c05f743b62.sh: line 1: sbt: command not found

https://github.com/spice-labs-inc/goatrodeo/actions/runs/11351528638/job/31572292734?pr=22