Refactored FileWalker to separate the file walking functions (Zip, Apache Commons, now ISO) into separate methods
Added substantial documentation
🧠 Rationale Behind Change(s)
We will need to support a lot of different file container (Zip, TAR, ISO, etc.) types going forward. This refactor
is the first step and it adds support for ISO files
📝 Test Plan
There need to be the following things added to this branch before it's complete:
Example ISO files stored in the Spice Labs public R2 bucket. These ISOs should be downloaded and cached as part of test run
The tests need to be updated to ensure a clear error in case git-lfs is not enabled
📜 Documentation
Added substantial documentation
💣 Quality Control
(All items must be checked before a PR is merged)
Did you…
[x] Mention an issue number in the PR title?
[ ] Update the version # in the build file?
[x] Create new and/or update relevant existing tests?
[x] Create or update relevant documentation and/or diagrams?
[x] Comment your code?
[x] Fix any stray verbose logging (removing, or moving to debug / trace level)?
Before Merging…
Make sure the Quality Control boxes are all ticked
Make sure any open comments or conversations on the PR are resolved
💻 Description of Change(s) (w/ context)
Refactored
FileWalkerto separate the file walking functions (Zip, Apache Commons, now ISO) into separate methodsAdded substantial documentation
🧠 Rationale Behind Change(s)
We will need to support a lot of different file container (Zip, TAR, ISO, etc.) types going forward. This refactor is the first step and it adds support for ISO files
📝 Test Plan
There need to be the following things added to this branch before it's complete:
📜 Documentation
Added substantial documentation
💣 Quality Control
(All items must be checked before a PR is merged) Did you…
Before Merging…