spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.66k stars 730 forks source link

[custom apps] synced romanized lyrics sometimes not syncing with current song #2749

Closed olvchk closed 6 months ago

olvchk commented 10 months ago

πŸ” Have you checked Spicetify.app page for your issue?

πŸ” Is there already an issue for your problem?

β„Ή Environment / Computer Info

- Spotify version: 1.2.26.1187.g36b715a1
- Spicetify version: 2.29.1

πŸ“ Description

synced romanized lyrics not updating after clicking next and prev song

πŸ“Έ Screenshots

track 1

image lyric is match with current track

track 2

image lyric is not match with current track after clicking next track. lyric is for track 1

track 3

image lyric is not match with current track after clicking next track. lyric is for track 2

image lyric is not match with current track after clicking previous track. lyric is for track 2

rxri commented 10 months ago

I cannot reproduce your issue on my end. It works just fine, reloads the lyrics whenever you do it

olvchk commented 10 months ago

I cannot reproduce your issue on my end. It works just fine, reloads the lyrics whenever you do it

have you tried it with japanese songs?

rxri commented 10 months ago

cannot reproduce your issue on my end. It works just fine, reloads the lyrics whenever you do it

I used the same songs as you. It works as expected (reloads and fetches new lyrics when skipping to next song)

ohitstom commented 9 months ago

cannot reproduce your issue on my end. It works just fine, reloads the lyrics whenever you do it

I used the same songs as you. It works as expected (reloads and fetches new lyrics when skipping to next song)

i just had this same thing happen as im typing this, refuses to load the lyrics for the correct song, seems one song out of sync

catb0x commented 9 months ago

happens to me as well but now the lyrics js arent romanized anymore

ohitstom commented 9 months ago

This is definitely a consistent issue its just happened to me again in under 10 minutes of listening

I believe we had a similar issue to this in the past and it was an unnecessary use of await somewhere

edit: doing more research this issue crops up if you go back one song then forward one song after playing a song that has no lyrics from what ive observed, which is identical to the aforementioned issue i fixed in the past meaning someone must have reverted my fix during refactoring the conversion menu.

rxri commented 9 months ago

No one reverted anything. It's still without await. https://github.com/spicetify/spicetify-cli/blob/9b1afc8e70264e7b1eb962d53241fb6816cf4450/CustomApps/lyrics-plus/index.js#L550

ohitstom commented 9 months ago

No one reverted anything. It's still without await.

https://github.com/spicetify/spicetify-cli/blob/9b1afc8e70264e7b1eb962d53241fb6816cf4450/CustomApps/lyrics-plus/index.js#L550

wasnt trying to point fingers! was just an assumption on my end, are you still unable to replicate? the key is to go back and forward a few times ive found

rxri commented 9 months ago

No one reverted anything. It's still without await. https://github.com/spicetify/spicetify-cli/blob/9b1afc8e70264e7b1eb962d53241fb6816cf4450/CustomApps/lyrics-plus/index.js#L550

wasnt trying to point fingers! was just an assumption on my end, are you still unable to replicate? the key is to go back and forward a few times ive found

I cannot reproduce this issue even with going back and forward multiple times. I was doing it slowly and as fast as I can, and lyrics always changed. Though this issue may be related to the performance of your pc πŸ€·β€β™€οΈ

acanechan commented 9 months ago

Before version 2.31.0, the Chinese translation function was not working. I encountered the same problem in 2.31.0 while translating from Simplified Chinese to Traditional Chinese . However, everything works fine when I turn off the translation function.

Edit: I have found a temporary solution to the this problem. Although it’s not the best method, it can be used temporarily until the problem is resolved. Add β€˜ this.translateLyrics(); ’ to the following location in index.js

image

olvchk commented 8 months ago

No one reverted anything. It's still without await. https://github.com/spicetify/spicetify-cli/blob/9b1afc8e70264e7b1eb962d53241fb6816cf4450/CustomApps/lyrics-plus/index.js#L550

wasnt trying to point fingers! was just an assumption on my end, are you still unable to replicate? the key is to go back and forward a few times ive found

I cannot reproduce this issue even with going back and forward multiple times. I was doing it slowly and as fast as I can, and lyrics always changed. Though this issue may be related to the performance of your pc πŸ€·β€β™€οΈ

rather than related to performance of the pc, how about network performance? because i have a relatively slow network that is around 10mbps. I have also tested it with 2 of my devices within the same network but still encountered the same problem

rxri commented 7 months ago

Okay so, unless I get performance report that I will give instructions now on how to make it and export, I will close this issue since I cannot reproduce it.

How to make a performance report:

  1. Run spicetify enable-devtools in terminal
  2. Open up devtools by right clicking anywhere on Spotify, and then click on Inspect Element
  3. Go to Performance tab, and click first button to the left (next to refresh button) to start recoding
  4. Now, reproduce the issue by going back and forth between songs while staying on lyrics-plus page
  5. When you can reproduce it at least twice (will be easier to see) in the same session, pause the recording by clicking the same button, then click this button: image
  6. Save it somewhere and send the report here so I can take a look on that
olvchk commented 6 months ago

Okay so, unless I get performance report that I will give instructions now on how to make it and export, I will close this issue since I cannot reproduce it.

How to make a performance report:

  1. Run spicetify enable-devtools in terminal
  2. Open up devtools by right clicking anywhere on Spotify, and then click on Inspect Element
  3. Go to Performance tab, and click first button to the left (next to refresh button) to start recoding
  4. Now, reproduce the issue by going back and forth between songs while staying on lyrics-plus page
  5. When you can reproduce it at least twice (will be easier to see) in the same session, pause the recording by clicking the same button, then click this button: image
  6. Save it somewhere and send the report here so I can take a look on that

Please check the performance report here. Trace-20240418T235613.json.zip

I start with lyric-plus opened, then start playing first track and the lyric is still fine. but after clicking next track, lyric is not synced

ak8000 commented 6 months ago

I had the same issue and came tracking open issues for this. Not really sure why, as when I try to reproduce it again, everything is as normal. Spotify for macOS (Apple Silicon) 1.2.35.663.gb699649e Spicetify v2.36.5

ohitstom commented 6 months ago

image this error cropped up after a few instances of becoming unsynced all though this error doesnt always show up