spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.63k stars 732 forks source link

pop up lyrics freezes upon minmize spotify #2827

Closed mazenR closed 8 months ago

mazenR commented 9 months ago

🔍 Have you checked Spicetify.app page for your issue?

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: latest
- Spicetify version:latest

📝 Description

pop up lyrics freezes upon minmize spotify

📸 Screenshots

image

rxri commented 8 months ago

There’s not something like latest. This has been already fixed. Reinstall spicetify if you are on 2.31.2

Steinadler177 commented 7 months ago

I'm facing a simliar problem. The pop up lyrics freezes when minimize spotify main window. It keeps frezze even if I reopen mainwindow (not restart the whole app). Then close pop up and re-open it can make it work again.

Spotify Windows(64 bit) version 1.2.33.1042.g26c92729 Spicetify v2.36.0 Theme: BurntSienna / Base Extensions: adblock.js, songstats.js, bookmark.js, oneko.js, CoverAmbience.js, playing-source.js, popupLyrics.js Custom apps: marketplace

JasonLovesDoggo commented 7 months ago

I face the same issue. As soon as I Alt+Tab it freezes.

Spotify for Windows (64 bit) 1.2.33.1042.g26c92729 Spicetify v2.36.2 Theme: Bloom / comfy Extensions: volumePercentageWrapper.js, playlistIntersection.js, power-bar.js, QueueTime.js, section-marker.js, phraseToPlaylist.js, spotifyGenres.js, made-for-you-shortcut.js, popupLyrics.js, theme.js Custom apps: marketplace

rxri commented 7 months ago

https://github.com/spicetify/spicetify-cli/issues/2749#issuecomment-2028110120 Please read the information from this link, otherwise I cannot acknowledge this issue since I cannot reproduce it.

Steinadler177 commented 7 months ago

Trace-20240402T141536.zip

#2749 (comment) Please read the information from this link, otherwise I cannot acknowledge this issue since I cannot reproduce it.

Please find the performance report here. I checked it, it was a little messed up by cat(oneko)... Tell me if you need a cleaner one.

What I did with the performance report: I start with song playing and lyrics tab closed. Then I open the tab, it works correctly. I switch my focus to dev window(so spotify main window still showing), the tab is still working fine. Then I minimized the main window, lyrics tab freezed. I open the main window back, but the tab is still freezing. I closed the tab and reopen it, it works. Minimized the main window, it freezes again.

rxri commented 7 months ago

Add popupLyrics to the config and do not install it via marketplace. spicetify config extensions popupLyrics.js, remove it from marketplace and run spicetify apply, then do this report again if it still happens

Steinadler177 commented 7 months ago

Add popupLyrics to the config and do not install it via marketplace. spicetify config extensions popupLyrics.js, remove it from marketplace and run spicetify apply, then do this report again if it still happens

Amazing, now it worked! It won't freeze even if I minimize the main window

What I did:

  1. remove it from market place
  2. reload and close spotify
  3. spicetify config extensions popupLyrics.js
  4. spicetify apply
  5. start spotify

So it's a problem generated from installation method?

rxri commented 7 months ago

Most likely, yes. I think it's a default browser behavior... and if it's from local file it won't put massive restrictions...? I don't know and I don't wanna dig into this more xd

Steinadler177 commented 7 months ago

Most likely, yes. I think it's a default browser behavior... and if it's from local file it won't put massive restrictions...? I don't know and I don't wanna dig into this more xd

I agree. But I also suggest to add this in readme file / somewhere so people know how to install it correctly

zubairmh commented 7 months ago

Add popupLyrics to the config and do not install it via marketplace. spicetify config extensions popupLyrics.js, remove it from marketplace and run spicetify apply, then do this report again if it still happens

can confirm this fixes the issue, unsure why marketplace variant wouldn't work