spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.08k stars 717 forks source link

[core] can't switch devices or logout #2869

Closed iPixelGalaxy closed 6 months ago

iPixelGalaxy commented 6 months ago

🔍 Have you checked Spicetify.app page for your issue?

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: 1.2.32.997.g4c6498b6
- Spicetify version: v2.33.0

📝 Description

Try to switch devices. Video of the issue: https://ipixelgalaxy.com/TempFiles/Spicetify%20Device%20Issue.mp4

📸 Screenshots

No response

rxri commented 6 months ago

Not related to spicetify. Reinstall Spotify

iPixelGalaxy commented 6 months ago

Reinstalled Spotify and all spicetify files in local appdata and roaming, no extensions running spotify clean install installed spotify 1.2.31 and issue is still present with latest spicetify, any logs I can provide?

ohitstom commented 6 months ago

Reinstalled Spotify and all spicetify files in local appdata and roaming, no extensions running spotify clean install installed spotify 1.2.31 and issue is still present with latest spicetify, any logs I can provide?

I did notice spicetify was preventing me from logging out, is this the same for you?

as for logs if you run spicetify enable-devtools from console you can inspect element for errors

iPixelGalaxy commented 6 months ago

Reinstalled Spotify and all spicetify files in local appdata and roaming, no extensions running spotify clean install installed spotify 1.2.31 and issue is still present with latest spicetify, any logs I can provide?

I did notice spicetify was preventing me from logging out, is this the same for you?

as for logs if you run spicetify enable-devtools from console you can inspect element for errors

actually yea logging out is broken for me as well

ohitstom commented 6 months ago

actually yea logging out is broken for me as well

@rxri I don't think this issue should have been closed he showed proof of unaltered Spotify not having this issue, and the logging out sounds like a similar issue

Arimodu commented 6 months ago

Hello, same issue here after updating from 2.32.1 to 2.33.0, logging out is also broken as well after spicetify update, as a sidenote can I downgrade or am I just stuck on this version now?

ohitstom commented 6 months ago

Hello, same issue here after updating from 2.32.1 to 2.33.0, logging out is also broken as well after spicetify update, as a sidenote can I downgrade or am I just stuck on this version now?

you can downgrade using command $v="2.32.1"; Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/spicetify/spicetify-cli/master/install.ps1" | Invoke-Expression

Arimodu commented 6 months ago

Thank you, after downgrade it works again

rxri commented 6 months ago

I think logging out is related to logging functions somehow - which is stupid to say the least, and connecting to devices could be also related to this. Until I will not confirm it for 100% this issue stays closed. Will check on it in few hours

rxri commented 6 months ago

@iPixelGalaxy I'm sharing the binary with included fix. Please let me know if that fixes the issue for you. To apply the fixed version run: spicetify restore backup apply after replacing binary inside %localappdata%\spicetify spicetify-2.33.1-Dev.zip (64-bit version)

iPixelGalaxy commented 6 months ago

@iPixelGalaxy I'm sharing the binary with included fix. Please let me know if that fixes the issue for you. To apply the fixed version run: spicetify restore backup apply after replacing binary inside %localappdata%\spicetify spicetify-2.33.1-Dev.zip (64-bit version)

It does seem to work, however I'm not sure if that's because it's fixed or because the CSS map is malformed according to the binary image

iPixelGalaxy commented 6 months ago

@rxri I built the binary myself from the fix/logging branch, and yes it does indeed seem to resolve both issues

https://github.com/spicetify/spicetify-cli/assets/42526028/685b141f-be22-4318-8757-fe535835051c

it does seem to be finicky once I swap a device once, I'm going to do a little testing, but I'm guessing that might be an issue with mismatched spotify versions on these devices

iPixelGalaxy commented 6 months ago

After compiling the new build for all my devices (my macbook included) and updating to latest spotify build, the issue does seem to be resolved 🥳

rxri commented 6 months ago

@iPixelGalaxy I'm sharing the binary with included fix. Please let me know if that fixes the issue for you. To apply the fixed version run: spicetify restore backup apply after replacing binary inside %localappdata%\spicetify spicetify-2.33.1-Dev.zip (64-bit version)

It does seem to work, however I'm not sure if that's because it's fixed or because the CSS map is malformed according to the binary image

yeah but it uses local one instead so it doesn't matter really. either way, good that it works Spotify relaying on logging methods to properly perform basic interactions is so funny. "Great company" basically