search

spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.13k stars 715 forks source link

[Lyrics Plus] LRCLIB Source #3027

Closed Overimagine1 closed 3 months ago

Overimagine1 commented 4 months ago

📝 Provide a description of the new feature

LRCLIB is a service that collects lyrics from various sources, including Musixmatch, but also allows users to submit their own synced lyrics. I assume this doesn't have as much lyrics as Musixmatch but it's nice if your other sources doesn't have what you want/is inaccurate.

➕ Additional Information

No response

Ed3151 commented 3 months ago

lyrics-plus.zip you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work copy both to CustomApps\lyrics-plus and run spicetify apply

ohitstom commented 3 months ago

lyrics-plus.zip you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work copy both to CustomApps\lyrics-plus and run spicetify apply

why didnt you make a PR

Ed3151 commented 3 months ago

Hello, I am totally new to github I don't know what is PR. is there any problem uploading file here

samuelawachie commented 3 months ago

lyrics-plus.zip you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work copy both to CustomApps\lyrics-plus and run spicetify apply

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

Ed3151 commented 3 months ago

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

uncheck spotify and netease if selected and select musximatch on spotify from lyrics plus config. it should work

samuelawachie commented 3 months ago

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

uncheck spotify and netease if selected and select musximatch on spotify from lyrics plus config. it should work

So you mean it doesn't "appear" on the Providers list? But it still uses it when only musixmatch is selected? How would one know it's working and installed then?

Ed3151 commented 3 months ago

So you mean it doesn't "appear" on the Providers list? But it still uses it when only musixmatch is selected? How would one know it's working and installed then?

yep it doesn't appear on Providers list on spotify app because I just added lrclib on musixmatch class, to make it work copy CustomApps\lyrics-plus and run spicetify apply and unselect everything except musixmatch and play any song like Mockingbird by Eminem as its lyrics doesn't contain on musixmatch api. its very simple

rxri commented 3 months ago

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

Ed3151 commented 3 months ago

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

rxri commented 3 months ago

I'm using whatever API endpoint it provides. If it's unreliable then it's not up to me to find workarounds. Per documentation it should work just fine, but I'm aware that sometimes, even when the song is in database, it returns with 404. This is the bug with lrclib and probably should be reported

samuelawachie commented 2 months ago

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

Hi again. How could I edit the script to put this option in? Coz it doesn't seem to be getting lyrics when I know that they exist in the lrclib database, and showed up in another app I use.

samuelawachie commented 2 months ago

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

Hi again. How could I edit the script to put this option in? Coz it doesn't seem to be getting lyrics when I know that they exist in the lrclib database, and showed up in another app I use.

I tried modifying the ProviderLRCLIB.js file and replaced the "const baseURL = "https://lrclib.net/api/get";" with "const baseURL = "https://lrclib.net/api/search?q=";" But that doesn't solve the issue, when I reckon that it should have. How else can one do this?

samuelawachie commented 2 months ago

Edit: It worked!! I changed it back to riri's configuration and now it's seeing the lyrics and loading them. I wonder why it didn't do that earlier.