search

spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.82k stars 735 forks source link

Spotify 1.2.46 causes spicetify to panic #3158

Closed craiggeil closed 2 months ago

craiggeil commented 2 months ago

🔍 Have you checked Spicetify.app page for your issue?

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: 1.2.46.462
- Spicetify version: 2.37.7

📝 Description

Try to install latest on Windows 11 machine Get the following error: Preprocessing: info Fetching remote CSS map for newer compatible tag version: main panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]: github.com/spicetify/cli/src/preprocess.exposeAPIs_main({0xc000588000, 0x1b617d}) /home/runner/work/cli/cli/src/preprocess/preprocess.go:564 +0x573 github.com/spicetify/cli/src/preprocess.Start.func1.1({0xc000c02000, 0x1b5b34}) /home/runner/work/cli/cli/src/preprocess/preprocess.go:103 +0x193 github.com/spicetify/cli/src/utils.ModifyFile({0xc001c08000, 0x43}, 0xc0000979e0) /home/runner/work/cli/cli/src/utils/utils.go:221 +0xb2 github.com/spicetify/cli/src/preprocess.Start.func1({0xc001c08000, 0x43}, {0xb45a08?, 0xc000134070?}, {0xc000097c80?, 0xa26c13?}) /home/runner/work/cli/cli/src/preprocess/preprocess.go:91 +0x152 path/filepath.walk({0xc001c08000, 0x43}, {0xb45a08, 0xc000134070}, 0xc000097c80) /opt/hostedtoolcache/go/1.21.13/x64/src/path/filepath/path.go:477 +0xff path/filepath.walk({0xc0000134c0, 0x3b}, {0xb45a08, 0xc001d5e000}, 0xc00009bc80) /opt/hostedtoolcache/go/1.21.13/x64/src/path/filepath/path.go:501 +0x257 path/filepath.Walk({0xc0000134c0, 0x3b}, 0xc00169fc80) /opt/hostedtoolcache/go/1.21.13/x64/src/path/filepath/path.go:572 +0x66 github.com/spicetify/cli/src/preprocess.Start({0xb41608, 0x6}, {0xc000012300?, 0x36?}, {0x0?, 0x0?, 0x0?, 0x0?}) /home/runner/work/cli/cli/src/preprocess/preprocess.go:85 +0x2b1 github.com/spicetify/cli/src/cmd.Backup({0xb41608, 0x6}) /home/runner/work/cli/cli/src/cmd/backup.go:68 +0x3dc main.main() /home/runner/work/cli/cli/spicetify.go:274 +0xb85 spicetify v2.37.7

📸 Screenshots

No response

amd64fox commented 2 months ago

show full version spotify

something like this: 1.2.46.462.gxxxxxxxx

craiggeil commented 2 months ago

gf57913e0

amd64fox commented 2 months ago

ty

links for those who want to reproduce this problem:

WIN32: https://upgrade.scdn.co/upgrade/client/win32-x86/spotify_installer-1.2.46.462.gf57913e0-290.exe

WIN64: https://upgrade.scdn.co/upgrade/client/win32-x86_64/spotify_installer-1.2.46.462.gf57913e0-290.exe

WIN-ARM64: https://upgrade.scdn.co/upgrade/client/win32-arm64/spotify_installer-1.2.46.462.gf57913e0-290.exe

OSX: https://upgrade.scdn.co/upgrade/client/osx-x86_64/spotify-autoupdate-1.2.46.462.gf57913e0-267.tbz

OSX-ARM64: https://upgrade.scdn.co/upgrade/client/osx-arm64/spotify-autoupdate-1.2.46.462.gf57913e0-267.tbz

rxri commented 2 months ago

Again, per spicetify release notes, we don't support 1.2.46. As this is fairly new version, don't expect us to fix it very fast

rxri commented 2 months ago

This panic has been resolved with https://github.com/spicetify/cli/commit/aa4ac602360f06836ac69e7bc995a9f9ae33159d. However navlinks have not been fixed yet