spicetify / cli

Command-line tool to customize Spotify client. Supports Windows, MacOS, and Linux.
https://spicetify.app
GNU Lesser General Public License v2.1
18.77k stars 734 forks source link

Unable to use F and `/` vim bindings #417

Closed matildeopbravo closed 3 years ago

matildeopbravo commented 3 years ago

I'm glad you like it! Your suggestions are reasonable, I should comply with keyboard-driven softwares out there instead of inventing my own keybinds.

I did make a few changes here: https://github.com/khanhas/spicetify-cli/blob/7f8205a50d69166bf865547e7a4ccbb277766f5a/Extensions/keyboardShortcut.js

If you have time, please test it out.

I added G/Shift+G scroll top/bottom, / to search, changed navigating forward/backward to shift+H/L, activate follow link function to F and added some documentation for users who want to change or add their own keybinds.

If you think of any more feature that are suitable for Spotify client, please do tell me.

Originally posted by @khanhas in https://github.com/khanhas/spicetify-cli/issues/27#issuecomment-500331931

According to khanhas, that feature has been implemented. However, despite having vim extension installed and being able to use every other feature, I can't seem to be able to use these two.

khanhas commented 3 years ago

Which two you can't use? I just checked and seems G/Shift+G, /, shift+H/L and f work fine on my end.

matildeopbravo commented 3 years ago

I can't use / and F @khanhas

khanhas commented 3 years ago

Oh sorry, I missed the title 😆 Do you have a custom keyboardShortcut.js? Can you run spicetify path -e so I can check its path. Just to be sure, here what to expect when you hit these buttons:

matildeopbravo commented 3 years ago

I ran the command you asked me to. image Btw, the f works fine. In your comment I saw capital f and I thought it was another binding(f + shift) but it was my mistake, it has worked all along. As for the search, sadly it does not work at all and it's a very important feature for me.

khanhas commented 3 years ago

I saw you put keyboardShortcut.js in your personal Extensions folder. keyboardShortcut.js comes with spicetify-cli package by default so I don't know if your keyboardShortcut.js misses feature or contains old code. Just delete it, make sure your spicetify is up-to-date and run spicetify apply.

matildeopbravo commented 3 years ago

I deleted it as you said but the problem remains.

khanhas commented 3 years ago

I have no idea what could cause just that specific key to stop working. Can you check console (hit Ctrl + Shift + i) and hit the / on Spotify client to see if there is any error on function the key bound to.

khanhas commented 3 years ago

I don't know if you know javascript. You might want to try run this function manually line by line in Console and see where the problem's at: https://github.com/khanhas/spicetify-cli/blob/master/Extensions/keyboardShortcut.js#L160

matildeopbravo commented 3 years ago

Ctrl + shift +i doesn't work either

khanhas commented 3 years ago

It's because you didn't enable devtool to access Console. Run this and try what I suggested again:

spicetify enable-devtool
matildeopbravo commented 3 years ago

I ran the command you told me to and I still couldn't access the console.

khanhas commented 3 years ago

😟 Right click at player bar and see if there is any context menu pop up. image

matildeopbravo commented 3 years ago

image That does work. I was able to open the devtools. I saw these issues

khanhas commented 3 years ago

Okay you got into Console, phew. Now focus on Spotify client and hit /, look at Console and see if there is any new error pop up. If not, run the code I pointed earlier, line by line and see where it goes wrong.