search

spicetify / marketplace

Download extensions and themes directly from Spicetify
MIT License
1.03k stars 174 forks source link

feat: improve settings dialog #792

Closed zhngharry closed 2 months ago

zhngharry commented 2 months ago

Based on #465

Improves the settings dialog CSS and turn tab order settings into draggable list. A user can hide a tab when clicking on it, reordering is done via drag and drop

Before: image

After: image

CharlieS1103 commented 2 months ago

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

rxri commented 2 months ago

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

He's aware of v3.

zhngharry commented 2 months ago

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

Yeah I know, but i'd already implemented most of it so i figured i'd just open the PR

I can recreate it in v3 if wanted

CharlieS1103 commented 2 months ago

@zhngharry In that case I'd be down to merge as long as @theRealPadster is as well, up to everyone else if they want a new release for it and such though.

theRealPadster commented 2 months ago

I'm down to merge it, I don't see any harm in some final QOL updates before v3

theRealPadster commented 2 months ago

Could we add some text to explain that you can click to disable them? It's not obvious. Maybe something like "drag and drop to reorder, click to toggle on and off"

zhngharry commented 2 months ago

Looks like this now

image