spicetify / spicetify-themes

A community-driven collection of themes for customizing Spotify through Spicetify - https://github.com/spicetify/cli
MIT License
5.11k stars 1.27k forks source link

StarryNight Galaxy Variant UI is broken after latest spotify update (extensions broke too) #1113

Closed Veran04 closed 1 month ago

Veran04 commented 1 month ago

Describe the bug After the most recent spotify update causing my UI to break, I did the same steps I usually take which are:

  1. Open command line
  2. type "spicetify update" Typically this is all I have to do and then my theme is reapplied. However in this case, the theme was applied in a very buggy way. You can see in the attached image that the panel on the right hand side (now playing view) takes up half the screen, and the bar you would typically drag to resize this does not work. I also get an error about needing to run the command spicetify sidebar_config 0 so I tried that and reapplied which made me stop receiving the error message but did not fix any of the UI issues. My extensions (shuffle+) are also not working currently.

To Reproduce See above

Expected behavior The theme will allow me to resize the view on the right hand side normally, and the shuffle+ extension will work again

Screenshots {095BA4D1-605B-4A1E-B9C0-871015086070}

Logs Add logs from console. To do that

  1. Run spicetify enable-devtools in terminal
  2. Spotify will be restarted
  3. Hit Ctrl + Shift + I to open DevTools window
  4. Navigate to tab Console
  5. Copy console window content.
index.html:1 document.domain mutation is ignored because the surrounding agent cluster is origin-keyed.
(anonymous) @ index.html:1
CircularSp-Bold.woff2:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
CircularSp-Book.woff2:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
CircularSpTitle-Bold.woff2:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
CircularSpTitle-Black.woff2:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:453 [spicetifyWrapper] Waiting for required webpack modules to load
4151.css:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
favicon.ico:1 

       Failed to load resource: net::ERR_NAME_NOT_RESOLVED
spicetifyWrapper.js:474 [spicetifyWrapper] All required webpack modules loaded
theme.js:88 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at theme.js:88:16
    at waitForElement (theme.js:4:5)
extension.js:8 Initializing Spicetify Marketplace v1.0.2
extension.js:8 Loaded Marketplace extension
gue1-spclient.spotify.com/remote-config-resolver/v3/configuration:1 

       Failed to load resource: the server responded with a status of 404 ()
vendor~xpui.js:1 provider:transport resolve error e Object
g @ vendor~xpui.js:1
index.html:1 Uncaught (in promise) e
8The resource <URL> was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.

Specifics (please complete the following information):

Veran04 commented 1 month ago

Shuffle+ is now working again after the latest Spicetify update (2.38.4) but my theme is still broken (cant resize right hand panel, cant access the home button, no search bar at the top)

b-chen00 commented 1 month ago

Do you have any other installed snippets or extensions? I see the issue with the right hand panel which works only when the "Now playing view" is open. I will find a better solution for that but I am not able to replicate the missing home button and search bar.

Veran04 commented 1 month ago

How would I view my installed snippets/extensions? Normally I'd click the marketplace button at the upper left but I am not seeing that either as part of this issue. Should I try reinstalling the theme?

b-chen00 commented 1 month ago

The theme shouldn't have made the marketplace button + top bar disappear as it doesn't touch that part of the Spotify client.

I noticed how there is an error message in your screenshot. Try the command and see if that fixes it. image

For this issue and the other issues you noticed, they're most likely not due to the theme as the theme doesn't directly affect those part of the client. I would point you to the Spicetify discord to see if there was a similar problem or potentially a solution.

However, the resizing problem is definitely due to the theme and I will be working on a fix for that though.

Veran04 commented 1 month ago

I tried running that command, it didn't change anything unfortunately. I also tried making a post on the main spotify-cli issues page and it got deleted with a comment saying it's a theme issue, but you're saying it's not a theme issue so I am confused on where to proceed. thank you again for being so patient with me and helping cause I really love the theme and spicetify and wanna keep using it

b-chen00 commented 1 month ago

Interesting, are you able to switch to a different theme? My suggestion right now is to remove the StarryNight theme in order to see if the navbar comes back. You could also try to reset experimental features.

image

If you are proficient with css or using the inspect tool, you can try to see what is happening to the global navbar element using spicetify enable-devtools

image

Also don't worry about it, I just hope I can be of help

Veran04 commented 1 month ago

Gonna give this all a shot tonight when I get home or at the latest tomorrow afternoon after work and then I will get back to you with how it goes - thanks again man

Veran04 commented 1 month ago

{E8C8F3A1-10A9-44C3-950A-34CB12528DAF} It seems like it is indeed a theme issue as everything looks fine after running "spicetify restore" to set things back to defaults. Any suggestions on how to proceed? Do I need to pull an updated version of the theme, I havent done that in a while not sure if it is automatic

b-chen00 commented 1 month ago

"spicetify restore" removes everything including Spicetify itself and brings you back to normal Spotify so there isn't much to go off of that alone. Version of theme should be automatic. See if there's any extension installed in your config-xpui.ini file at the line "extensions = " which can be found in

image

Other than that try to reset your experimental features as shown above and uninstalling and reinstalling spicetify. Not sure if that will do anything but worth a shot. Also make sure spicetify is updated with spicetify update just in case

In nothing works, I could hop in a discord call and take a closer look

b-chen00 commented 1 month ago

If you want to remove the StarryNight theme and see if it is causing the issue you can delete it by

running "spicetify enable-devtools", right clicking the spotify client click show devtools navigate to the Application tab into the local storage tab on the left delete all the values when searching for StarryNight

image

Veran04 commented 1 month ago

{F5A749DB-5DD7-4DC8-B76C-CFB41424019F} Extensions appears to be blank when running "spicetify config" and viewing the file through terminal. I verified by manually opening the file inside appdata with notepad as well and extensions is blank

I haven't been able to access that experimental features button from your screenshot since my profile icon is hidden by the bug and it seems like that is what you're clicking to access that.

Is there a way to backup my settings before I uninstall and reinstall? I assume "spicetify backup" does this and then I will run "spicetify backup restore": after reinstalling but just want to verify before I proceed with the uninstall to make sure I dont mess things up.

My discord is veran99 if you do want to add me there, but please don't feel obligated to do so

thanks a ton again

b-chen00 commented 1 month ago

You should be safe to uninstall and reinstall. Not too familiar with the backup commands myself as I don't use them when I reinstall which hasn't affected me so far. But, yea I think the commands are "spicetify backup" and "spicetify restore backup".

Also forgot that you need the navbar to reset experimental settings lol

Veran04 commented 1 month ago

{63F24F72-AAEF-4DF1-B5ED-08BFB117538E} After uninstalling and reinstalling spicetify, I still receive all of the same issues with the theme

Ran spicetify update just to verify that I am on latest (2.38.4) and I am

{0702E3D4-0463-48DA-8511-6BE4B1A41649} I see these errors in the console of devtools if they mean anything to you

{AE47BA3F-82AF-4A7F-9AE7-6B2AE512CCBC} There was 1 result in here when searching starrynight so I deleted it but it did not remove the theme, I still see the broken starrynight theme

b-chen00 commented 1 month ago

Will try to set up a call

Veran04 commented 1 month ago

Resolved over a discord call with Brandon - If anyone else encounters this issue, the fix was to manually redownload the spicetify-themes repo and overwrite my installation with latest