spicetify / spicetify-themes

A community-driven collection of themes for customizing Spotify through Spicetify - https://github.com/spicetify/cli
MIT License
5.13k stars 1.27k forks source link

Now playing not centered on Dribbblish #193

Closed TheJaake closed 4 years ago

TheJaake commented 4 years ago

After stretching the Dribbblish theme horizontally, the now-playing section is shifted to the right. This problem remains after a restart of the client and even a complete reinstall. I attempted editing the CSS myself, but to no avail. The dribbblish.js does imply that the now-playing section is centered, but the problem seems to be located in the underlying layer.

I am running dwm window manager on Fedora Linux and using the Flatpak installation of Spotify.

dribblish

dofrancis commented 4 years ago

I have the same problem. It happens on i3, dwm, and kde on Arch Linux. Same thing happens on windows too.

MyYogurt commented 4 years ago

Can recreate problem on MacOS

JulienMaille commented 4 years ago

Can you guys try to enter dev mode, remove this from user.css and see if it helps?

.view-player .now-playing .cover-image-link-wrapper {
    width: var(--bar-cover-art-size);
    height: var(--bar-cover-art-size);
dofrancis commented 4 years ago

Can you guys try to enter dev mode, remove this from user.css and see if it helps?

.view-player .now-playing .cover-image-link-wrapper {
    width: var(--bar-cover-art-size);
    height: var(--bar-cover-art-size);

tmp2

I believe the fix you said only moves the cover picture up.

JulienMaille commented 4 years ago

I don't have this issue under Windows, that's weird

dofrancis commented 4 years ago

https://github.com/morpheusthewhite/spicetify-themes/blob/master/Dribbblish/user.css#L1212

You were talking about these lines right? It's only off center when the window is wide to a certain point.

Edit:

I think it has something to do with these lines: https://github.com/morpheusthewhite/spicetify-themes/blob/master/Dribbblish/user.css#L1098. I don't know css, but changing the value of flex changed where the now playing stuff is located.

JulienMaille commented 4 years ago

Can you try this

.view-player .now-playing-container {
    max-width: none !important;
}
dofrancis commented 4 years ago

Can you try this

.view-player .now-playing-container {
    max-width: none !important;
}

tmp3

This seemed to work. Thank you very much.

JulienMaille commented 4 years ago

May I suggest to try DrribbblishDynamic :) ?

dofrancis commented 4 years ago

I tried it, but the translucency for the album art was a little over what I prefer. Also, I have a little theme going on, and the colors changing constantly doesn't work for me. Other than that it works fine.

TheJaake commented 4 years ago

Can you try this

.view-player .now-playing-container {
    max-width: none !important;
}

After making this change in the user.css file and re-applying, the now-playing section doesn't shift nearly as far to the right as it had before, but on my ultrawide, the problem persists. dribbblish