spicetify / spicetify-themes

A community-driven collection of themes for customizing Spotify through Spicetify - https://github.com/spicetify/cli
MIT License
4.98k stars 1.26k forks source link

[DribbblishDynamic] Tooltips unreadable #343

Closed DatAres37 closed 3 years ago

DatAres37 commented 3 years ago

Describe the bug Tooltips are (almost) unreadable when hovering over them. The song/color doesn't matter.

To Reproduce Steps to reproduce the behavior:

  1. Hover over the playlist images on the left side, an artist, an album name etc.

Expected behavior A light tooltip font for the dark theme and a dark one for the white theme.

Screenshots

spi-dark spi-white

Logs

Uncaught TypeError: Cannot read property 'length' of undefined
    at zlink.bundle.js:495
    at zlink.bundle.js:495
    at zlink.bundle.js:495
    at zlink.bundle.js:495
    at zlink.bundle.js:495
DevTools failed to load SourceMap: Could not load content for https://zlink.app.spotify.com/css/zlink.css.map: 
DevTools failed to load SourceMap: Could not load content for https://buddy-list.app.spotify.com/css/buddy-list.css.map: 
DevTools failed to load SourceMap: Could not load content for https://zlink.app.spotify.com/zlink.bundle.js.map: 
DevTools failed to load SourceMap: Could not load content for https://buddy-list.app.spotify.com/buddy-list.bundle.js.map: 

Specifics (please complete the following information):

JulienMaille commented 3 years ago

See #342, make sure you work with latest commits

DatAres37 commented 3 years ago

I just downloaded the theme again to make sure, but the problem persists. No issues with the normal Dribbblish theme.

I also don't have the issue mentioned in #342, the tooltip on the progress bar works as expected, but most of the other tooltips don't. The tooltips have the background of the generated colour, but the font should be white, not black: grafik

Can a KDE theme somehow interfere with a spicetify theme?

My config:

[AdditionalOptions]
experimental_features        = 0
lyric_force_no_sync          = 0
radio                        = 0
visualization_high_framerate = 0
extensions                   = dribbblish-dynamic.js
custom_apps                  = genius
fastUser_switching           = 0
home                         = 0
lyric_always_show            = 0
song_page                    = 0

[Setting]
spotify_path            = /opt/spotify
prefs_path              = /home/user/.config/spotify/prefs
current_theme           = DribbblishDynamic
color_scheme            = dark
inject_css              = 1
replace_colors          = 1
spotify_launch_flags    =
check_spicetify_upgrade = 0
overwrite_assets        = 1

[Preprocesses]
remove_rtl_rule       = 1
expose_apis           = 1
disable_upgrade_check = 1
disable_sentry        = 1
disable_ui_logging    = 1
morpheusthewhite commented 3 years ago

Did you run again the commands in the README?

gordon-z commented 3 years ago

Having same issue, tried latest commit as well but problem persists. After modifying the C:\Users\Gordon.spicetify\Themes\DribbblishDynamic\user.css to latest commit, I ran spicetify update followed by spicetify apply, but nothing changed. Screenshot attached below. dribbblishDynamic usercss.txt

Also ran command in README as well, to no avail.

DatAres37 commented 3 years ago

Did you run again the commands in the README?

The install commands? Yes

JulienMaille commented 3 years ago

Can you show me the css rule responsible for the tooltip text color, using the developer console?

gordon-z commented 3 years ago
#tooltip,
.Tooltip {
    box-shadow: 0 0 4px rgba(0, 0, 0, 0.2) !important;
    border-radius: 4px !important;
    background-color: var(--modspotify_indicator_fg_and_button_bg);
    color: var(--modspotify_main_bg);
    padding: 10px 10px;

    backface-visibility: hidden;
    transform: translateZ(0);
    backdrop-filter: blur(20px);
}

I found it, the root cause is color: var(--modspotify_main_bg); I changed it to color: var(--modspotify_secondary_fg); and it's now clearly visible.

JulienMaille commented 3 years ago

No side effect on other tooltips?

gordon-z commented 3 years ago

Looks good for the tooltips I've tested so far. All of the left pane, friend activity, and personal profile work well.

Here is an example screenshot: dribbblishDynamicWorking

JulienMaille commented 3 years ago

What about tooltips from topbar items and the progressbar's one?

gordon-z commented 3 years ago

topbar progressbar