search

spicetify / spicetify-themes

A community-driven collection of themes for customizing Spotify through Spicetify - https://github.com/spicetify/cli
MIT License
5.13k stars 1.27k forks source link

[Fluent] Sidebar Playlist icons bug #613

Closed cyberniinja closed 2 years ago

cyberniinja commented 3 years ago

Describe the bug When Scrolling down in the sidebar, the Playlist Pictures disappear. Maybe something similar to #567?

To Reproduce Steps to reproduce the behavior:

  1. Start spotify.
  2. Scroll down to the bottom in the left sidebar with the playlists
  3. Scroll up to to the top again
  4. All the playlist icons that were scrolled "under" the Liked Songs, now have no icons.

Expected behavior When scrolling down and up again, the playlist icons don't change at all.

Screenshots Step 1 - Before: image

Step 2 - Scroll down: image

Step 3 - Scroll up again: image

Logs

fluent.js:77 Uncaught TypeError: Cannot read properties of undefined (reading 'Translations')
    at fluent.js:77
vendor~xpui.js:29 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 change listeners added. Use emitter.setMaxListeners() to increase limit
    at c (https://xpui.app.spotify.com/vendor~xpui.js:29:2492684)
    at t.o.addListener (https://xpui.app.spotify.com/vendor~xpui.js:29:2495268)
    at https://xpui.app.spotify.com/vendor~xpui.js:29:2135437
    at Pa (https://xpui.app.spotify.com/vendor~xpui.js:29:2730563)
    at ks (https://xpui.app.spotify.com/vendor~xpui.js:29:2754295)
    at t.unstable_runWithPriority (https://xpui.app.spotify.com/vendor~xpui.js:29:2967887)
    at hi (https://xpui.app.spotify.com/vendor~xpui.js:29:2700099)
    at Is (https://xpui.app.spotify.com/vendor~xpui.js:29:2754074)
    at Os (https://xpui.app.spotify.com/vendor~xpui.js:29:2738953)
    at vs (https://xpui.app.spotify.com/vendor~xpui.js:29:2737875)
c @ vendor~xpui.js:29
xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/vendor~xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/644.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-routes-homepage-takeover-ad.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/596.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-routes-home.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-modals.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED

Specifics

williamckha commented 3 years ago

Did you follow all installation instructions? For the sidebar playlists to show properly, ensure that these two lines are added in the Patch section of your config-xpui.ini file:


[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,
alexklann commented 3 years ago

Did you follow all installation instructions? For the sidebar playlists to show properly, ensure that these two lines are added in the Patch section of your config-xpui.ini file:

[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,

I still have the same problem after adding the two lines.

cyberniinja commented 3 years ago

Did you follow all installation instructions? For the sidebar playlists to show properly, ensure that these two lines are added in the Patch section of your config-xpui.ini file:

[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,

yeah, I redownloaded and installed everything before writing the bug report. I hadn't put the patches, before but I also still have the problem after adding them. Log output hasnt changed either...

UmerF commented 3 years ago

Any fix to this? My Spotify just updated and now all the icons are gone, doesn't matter of I scroll down or not.

stefanw1337 commented 3 years ago

Lines were in there already for me, but I also are getting no icons, or rather "error" icons than no icons: https://i.postimg.cc/qqdJtWP7/image.png

williamckha commented 3 years ago

You must disable dribblish.js if you have enabled it in config

stefanw1337 commented 3 years ago

Isn't that uninstalling the theme? lol, quite opposite of what I'm trying to do! Also this is the "folders", the actual playlist icons work.

From: William Ha @.> Sent: Thursday, November 25, 2021 8:50:38 PM To: morpheusthewhite/spicetify-themes @.> Cc: stefanw1337 @.>; Comment @.> Subject: Re: [morpheusthewhite/spicetify-themes] [Fluent] Sidebar Playlist icons bug (Issue #613)

You must disable dribblish.js if you have enabled it in config

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/morpheusthewhite/spicetify-themes/issues/613#issuecomment-979443755, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADR3YAURJMYRGQNUEC2C7RLUN2HQ5ANCNFSM5IGRNULQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

williamckha commented 3 years ago

Are you using Fluent theme or Dribblish?

stefanw1337 commented 3 years ago

Dribbblish with Nord-Dark theme

cyberniinja commented 3 years ago

Dribbblish with Nord-Dark theme

This is an issue that concerns the fluent theme :)

williamckha commented 3 years ago

Not sure what is causing this issue, can you try increasing the timeout in fluent.js like shown: https://github.com/williamckha/spicetify-fluent/commit/4e02067268b1c876f4f3e5df49d0448ded663227 and see if it fixes the issue? Or you can try reinstalling Fluent from my repo https://github.com/williamckha/spicetify-fluent/

UmerF commented 3 years ago

Not sure what is causing this issue, can you try increasing the timeout in fluent.js like shown: williamckha/spicetify-fluent@4e02067 and see if it fixes the issue? Or you can try reinstalling Fluent from my repo https://github.com/williamckha/spicetify-fluent/

Long shot, but just confirming. My Spicetify version is upgraded and it's 2.8.2, and your repo mentions 2.7.0 — is that just an old edit, or it's meant to only work on that Spicetify version?

Thanks.

williamckha commented 3 years ago

Long shot, but just confirming. My Spicetify version is upgraded and it's 2.8.2, and your repo mentions 2.7.0 — is that just an old edit, or it's meant to only work on that Spicetify version?

Thanks.

It's an old edit. Everything's working for me on spicetify 2.8.3

UmerF commented 3 years ago

Long shot, but just confirming. My Spicetify version is upgraded and it's 2.8.2, and your repo mentions 2.7.0 — is that just an old edit, or it's meant to only work on that Spicetify version? Thanks.

It's an old edit. Everything's working for me on spicetify 2.8.3

Hmm, odd. But if it's working for you, I guess I could try a fresh install, delete everything and do it from scratch.

cyberniinja commented 3 years ago

Not sure what is causing this issue, can you try increasing the timeout in fluent.js like shown: williamckha/spicetify-fluent@4e02067 and see if it fixes the issue? Or you can try reinstalling Fluent from my repo https://github.com/williamckha/spicetify-fluent/

Okay, so I tried increasing the timeout before reinstalling fluent from your repo. neither worked. I increased it after reinstalling too, but that didn't fix it either. I'll try to debug it later. Do you want me to close this issue and open it in your repo?

(Oh and I'm up to v2.8.3 spiceitfy aswell, but that didnt change anything)

williamckha commented 3 years ago

Not sure what is causing this issue, can you try increasing the timeout in fluent.js like shown: williamckha/spicetify-fluent@4e02067 and see if it fixes the issue? Or you can try reinstalling Fluent from my repo https://github.com/williamckha/spicetify-fluent/

Okay, so I tried increasing the timeout before reinstalling fluent from your repo. neither worked. I increased it after reinstalling too, but that didn't fix it either. I'll try to debug it later. Do you want me to close this issue and open it in your repo?

You can open an issue in my repo, but keep this issue open until it is resolved/commits are made to this repo. Thanks!

afonsojramos commented 2 years ago

Fluent is now being developed here. Thank you!