search

spicygreenbook / greenbook-app

We are Spicy Green Book – a virtual directory for Black-owned food and beverage businesses throughout the US and Canada. We help Black-owned food and drink business owners tell their story, sowing the seeds of trust, support, and positive change within local communities.
https://www.spicygreenbook.org
46 stars 60 forks source link

Sponsor Page: Fix Header #336

Closed heyitsbuse closed 3 years ago

heyitsbuse commented 3 years ago

Hi! I'm the Designer who created the Sponsor Page. I'm creating mini issues to cover the most important updates so that the website can better match the prototype: https://quiet-bird-3981.animaapp.io/

1) This webpage requires a special header where the secondary navigation (green section) is also fixed. See prototype for demo. I understand that on mobile, this will not be achievable. NOT FIXED => EXTRACTED TO #343

2) For the jump links within the secondary navigation, please edit the position at which the page jumps to because you need to account for the header taking up space. Currently, the section titles are getting covered up. FIXED (as good as it gets on mobile with current implementation)

3) Match the height of the black CTA button "Become a Sponsor" in the secondary navigation to the green CTA button "Become a Sponsor" button later down the page so that they both have 60px height. FIXED

4) For CTA buttons, currently text is the only clickable area for the mailto link. Change that so that the entire rectangle is clickable. FIXED

Comment on this issue or DM me on slack if you have any questions!

JeroenGoddijn commented 3 years ago

Item 2 has been fixed. Will work on rest tomorrow

C-Garza commented 3 years ago

@JeroenGoddijn I also noticed another issue and that is when the web screen size is smaller than 1100px, the Sponsor Us navigation link does not appear in the hamburger menu.

JeroenGoddijn commented 3 years ago

@JeroenGoddijn I also noticed another issue and that is when the web screen size is smaller than 1100px, the Sponsor Us navigation link does not appear in the hamburger menu.

@C-Garza is that issue 339 ??? Because I noticed that item missing as well.

I just quickly fixed the scrolling issue on existing implementation, as Danilo asked me and said that was most urgent

C-Garza commented 3 years ago

Yes that is, I must have just missed seeing that issue when I commented here.

JeroenGoddijn commented 3 years ago

No worries. Just making sure we're talking about the same thing

JeroenGoddijn commented 3 years ago

@heyitsbuse Please check the fixes here and let me know if this works/looks as expected

This now includes the fix for issue #333

heyitsbuse commented 3 years ago

Hi, only #3 from my list of requests were actioned. Still need to fix #1, #2, and #4. Please look at the prototype for intent.

JeroenGoddijn commented 3 years ago

Hi, only #3 from my list of requests were actioned. Still need to fix #1, #2, and #4. Please look at the prototype for intent.

Not sure where you looked, but for me all items are working now; except for item 1, because that seemed like an informational statement without a specific change request when I read it initially. However, #333 makes it impossible to test item 3 now, as it is temporarily removed.