App Home Page Overlay and Menu

spicygreenbook / greenbook-app

We are Spicy Green Book – a virtual directory for Black-owned food and beverage businesses throughout the US and Canada. We help Black-owned food and drink business owners tell their story, sowing the seeds of trust, support, and positive change within local communities.

https://www.spicygreenbook.org

46 stars 60 forks source link

App Home Page Overlay and Menu #362

Closed danilobatson closed 3 years ago

danilobatson commented 3 years ago

Put dark overlay over the image so that the text contrasts better.

Decrease height of navigation bar so there's more room for content

Original:

_Recommendations are coming from this audit_

RoseKimball commented 3 years ago

I'll handle this change

RoseKimball commented 3 years ago

Hi, I am not able to finish the second part involving bottom navigation menu. Someone else should finish this part.

lirondco commented 3 years ago

Hi, I can take over for the second part involving the navigation menu.

lirondco commented 3 years ago

Second part has been implemented. While working on it, I did discover that there are two Custom Drawers that are being rendered. I'm not sure if there was a design / performance decision behind choosing one over the other so I left it as is.

Here is the code:

Component CustomDrawerContent is the one being rendered into the live app and it looks like this:

Simulator Screen Shot - iPhone SE (2nd generation) - 2021-05-06 at 15 37 56]

While the one that is not active but is still being called looks like this:

Simulator Screen Shot - iPhone SE (2nd generation) - 2021-05-06 at 15 39 09

mrvncaragay commented 3 years ago

Hi @lirondco nice work. I am also updating the navigation and this seems have a conflict with #363. @danilobatson can you clarify whether to remove the hamburger all together. thanks!

lirondco commented 3 years ago

Drawer issue has been fixed in #394.