search

spicygreenbook / greenbook-app

We are Spicy Green Book – a virtual directory for Black-owned food and beverage businesses throughout the US and Canada. We help Black-owned food and drink business owners tell their story, sowing the seeds of trust, support, and positive change within local communities.
https://www.spicygreenbook.org
46 stars 60 forks source link

URGENT: Volunteer Button Missing Text #364

Closed danilobatson closed 3 years ago

danilobatson commented 3 years ago

Describe the bug Not sure what happened here but the text that was on the link to the volunteer form is now missing.

See photo below and notice empty green box

To Reproduce Steps to reproduce the behavior:

  1. Go to spicygreenbook.org/volunteer
  2. Scroll down
  3. See error

Screenshots image

Desktop (please complete the following information):

codecustard commented 3 years ago

https://github.com/spicygreenbook/greenbook-app/blob/0f8dfe98a4a16652a95398b60cc1451e104865f7/screens/Volunteer.js#L184

https://github.com/spicygreenbook/greenbook-app/blob/0f8dfe98a4a16652a95398b60cc1451e104865f7/utils/getStyles.js#L248-L256

Looks like a mixup with the theming... Depending on the context of "button text color" should use: 'button_white_text' or change the color property of "button_green_text".

@JeroenGoddijn

C-Garza commented 3 years ago

Yeah, if the colors are changed now then the buttons have to be updated. The homepage has some buttons with the same issue. He must have fixed the colors because button_green_text was white, but I guess in the context of the old style, it was meant for text in green buttons, which is kind of confusing.

danilobatson commented 3 years ago

This issue is relevant to issue #365

JeroenGoddijn commented 3 years ago

I will have a look later today, but pretty sure I reverted that change in commit/deployment few days ago. Right after I initially edited them.

So, somehow somewhere someone committed a fix with an older version where it was still wrong (or I could have done that accidentally myself)

Easy fix though, as we can just grab older version of getStyles.js from a previous commit and restore that one

JeroenGoddijn commented 3 years ago

Fix is being deployed at the moment.