search

spicywebau / craft-embedded-assets

Manage YouTube videos, Instagram photos, Twitter posts and more as first class assets in Craft CMS
MIT License
171 stars 34 forks source link

getVideoId not working with Dailymotion #222

Closed romainpoirier closed 1 year ago

romainpoirier commented 1 year ago

Bug Description

Add this test URL to embeds: https://www.dailymotion.com/video/x6yvds. The embed is correctly imported, and is showing up. We can see that there are infos in the created JSON. However, we can't print out the video ID because embed.getVideoId() returns nothing. If trying with a YouTube or Vimeo video, this is working fine: we can get the video using this method.

Steps to reproduce

  1. Prepare embed as usual: {% set embed = craft.embeddedAssets.get(asset) %}
  2. Try to print the video ID: embed.getVideoId()
  3. No value

Expected behaviour

No response

Embedded Assets version

3.1.0

Craft CMS version

4.3.6

ttempleton commented 1 year ago

getVideoId() currently only supports YouTube and Vimeo videos, but Dailymotion support is something we can look at (pull requests welcome too!)

romainpoirier commented 1 year ago

It would be super nice if you could integrate it. Thank you 🙏

ttempleton commented 1 year ago

That should now be working with Embedded Assets 3.1.1.

romainpoirier commented 1 year ago

It works, thank you!