TypeError: Cannot read properties of undefined (reading 'folderId')

[arifje]

Bug Description

Since our update to Craft 4.5.1 and Embedded Assets 3.1.6, we can't save the embeds anymore.

main.ts:67 Uncaught TypeError: Cannot read properties of undefined (reading 'folderId')
    at o.c [as _currentGetActionTarget] (main.ts:67:32)
    at o._getActionTarget (EmbeddedAssets.ts:76:17)
    at h._getActionTarget (EmbeddedAssets.ts:17:39)
    at h.save (Form.ts:137:72)
    at HTMLDivElement.<anonymous> (Modal.ts:57:45)
    at HTMLDivElement.dispatch (jquery.js?v=1692888808:2:43392)
    at v.handle (jquery.js?v=1692888808:2:41387)

Steps to reproduce

• Create an entry
• Add an embed
• Copy paste the URL of a Youtube video
• The preview modal pops up
• Pressing save generates Javascript error
• Asset is not saved

Expected behaviour

No response

Embedded Assets version

3.1.6

Craft CMS version

4.5.1

[joshuabaker]

Also seeing this with Embedded Assets 3.1.6 and Craft 4.5.3. Clients are unable to update content as a result.

The error originates from the following line:

https://github.com/spicywebau/craft-embedded-assets/blob/b1d1fbac53b6e31718e95f709288c2e84dc90870/src/assets/main/src/scripts/main.ts#L67

It doesn’t look like sourcePath is present on the asset select input.

[joshuabaker]

Could be just that we need the extra check or optional chain as referencing properties of a non-object will throw.

Here’s a possible drop-in replacement for the getActionTarget method.

  const getActionTarget: () => Object = () => {
    if (Array.isArray(this.sourcePath)) {
      // Craft 4.4 subfolder compatibility
      const currentFolder = this.sourcePath[this.sourcePath.length - 1]

      if (currentFolder?.folderId) {
        return {
          targetType: 'folder',
          targetId: currentFolder.folderId
        }
      }
    }

    const [targetType, targetUid] = this.sourceKey.split(':')

    if (targetType && targetUid) {
      return { targetType, targetUid }
    }

    return {}
  }

I’ve also stripped the typeof checks in favour of clearer and type-checked conditions. It’s absolutely a personal preference, but I think the conditions and destructuring assignment syntax make it a bit more readable.

All of this is assuming that currentFolder should ever be nullish.

[ttempleton]

This is working as expected for me, e.g. the following screenshot shows me logging the sourcePath property:

Not really willing to make changes without being able to reproduce the error, since I don't want to make a change that breaks something else, and sourcePath is actually a Craft.AssetIndex property and I'm unsure what case causes it to be empty. Any extra information that could help identify the cause (e.g. a specific field configuration if this only happens when editing entries) is appreciated.

[joshuabaker]

Thanks, @ttempleton. Where are you seeing that array you’re referencing?

[joshuabaker]

Field settings

[arifje]

Our field config;

[ttempleton]

Thanks both - I can reproduce the error and it is related to the use of variables when restricting assets to a single location.

Just want to confirm that this has only started happening when upgrading to Craft 4.5? This is just for the purpose of updating the changelog.

[joshuabaker]

Thanks, @ttempleton. Glad we were able to help diagnose this.

I was seeing this with earlier versions (e.g. Craft 4.4.17).

[ttempleton]

Thanks - just released 3.1.7 with the fix.

[joshuabaker]

Amazing! Thanks, @ttempleton. Can confirm this is up and running again for us. 🙏🏻