search

spicywebau / craft-embedded-assets

Manage YouTube videos, Instagram photos, Twitter posts and more as first class assets in Craft CMS
MIT License
171 stars 34 forks source link

craft.embeddedAssets.get() returns null for embed uploaded prior to 4.0 upgrade #254

Closed johndwells closed 3 months ago

johndwells commented 3 months ago

Bug Description

We've just tested upgrading to V4.0, but now when we call craft.embeddedAssets.get() on a previously uploaded embed, the result is null. If we upload the same embed fresh, the call correctly returns an EmbeddedAsset model.

Steps to reproduce

  1. Install Embedded Assets 3.2.0
  2. Upload an embed (in our specific case this Vimeo video)
  3. Upgrade to Embedded Assets 4.0

Expected behaviour

I would expect embeds uploaded prior to upgrading to 4.0 remain compatible with 4.0 codebase. If this can be resolved by running the embeddedassets/refresh/all CLI command, then this should be specified in some sort of 4.0 upgrade guide.

Embedded Assets version

4.0.0

Craft CMS version

4.8.6

johndwells commented 3 months ago

I've just tried running embeddedassets/refresh/all but it said, "0 embedded asset to be refreshed." Yet we have 27 embedded asset uploads.

ttempleton commented 3 months ago

If possible, could you please send one of the affected asset files to plugins@spicyweb.com.au and we'll have a look.

ttempleton commented 3 months ago

Thanks for sending that @johndwells. I can confirm that the embedded asset is working as expected for me, including being detected by embeddedassets/refresh/all. Does it work for you if you import it into a different Craft install?

johndwells commented 3 months ago

Odd. I've tried this a few times on this project and the results are the same. We'll see if we can test this out on another install.

On Wed, Mar 27, 2024 at 6:08 PM Thomas Templeton @.***> wrote:

Thanks for sending that @johndwells https://github.com/johndwells. I can confirm that the embedded asset is working as expected for me, including being detected by embeddedassets/refresh/all. Does it work for you if you import it into a different Craft install?

— Reply to this email directly, view it on GitHub https://github.com/spicywebau/craft-embedded-assets/issues/254#issuecomment-2024129460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABAXXTJSIVZNCJZPMCNNODY2NGOLAVCNFSM6AAAAABFLNIY26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGEZDSNBWGA . You are receiving this because you were mentioned.Message ID: @.***>

-- ▂ ONE DARNLEY ROAD

John D Wells Technical Director

Unit 12, 39 Gransden Avenue London, E8 3QA +44 (0) 208 5259 292

onedarnleyroad.com instagram https://www.instagram.com/onedarnleyroad/ linkedin https://uk.linkedin.com/company/one-darnley-road twitter http://twitter.com/onedarnleyroad

johndwells commented 3 months ago

I think we had some other issue going on that was causing this error. I'm closing, sorry to bother you!