search

spicywebau / craft-embedded-assets

Manage YouTube videos, Instagram photos, Twitter posts and more as first class assets in Craft CMS
MIT License
171 stars 34 forks source link

Instagram renders as text #261

Open gijsstegehuis opened 1 month ago

gijsstegehuis commented 1 month ago

Bug Description

When embedding an Instagram post via URL it renders only text, not the regular Instagram embed code.

Steps to reproduce

  1. Embed any instagram post
  2. Render via {{ embeddedAsset.html }}

Expected behaviour

No response

Embedded Assets version

5.1.0

Craft CMS version

Craft Pro 5.1.2

ttempleton commented 1 month ago

I recommend setting up a test directly with the Embed package, that this plugin uses to get Instagram embeds, to see if it returns any embed code when used directly. We're not doing anything special to Instagram embeds when they're loaded, but I can't rule out some other plugin-specific issue affecting Instagram embeds. When testing that, make sure to set the API key (that you previously set as the Facebook key in Embedded Assets' plugin settings) in the way described at the bottom of the Embed readme.

gijsstegehuis commented 1 month ago

Thx! that gave me some more detailed info. It appears to be an issue with the Facebook Graph API we're using.

When using the embed package directly it returns: To use 'Oembed Read', your use of this endpoint must be reviewed and approved by Facebook. To submit this 'Oembed Read' feature for review please read our documentation on reviewable features: https://developers.facebook.com/docs/apps/review

This message is omitted when using this plugin, so this could be improved IMO.

ttempleton commented 2 weeks ago

Yeah, that's fair enough. Will put that on my todo list.