search

spicywebau / craft-fieldlabels

Override Craft CMS field labels and instructions in the field layout designer
MIT License
123 stars 9 forks source link

Fix issue where getIsGuest returns true when user is authenticated #18

Closed aaronbushnell closed 5 years ago

aaronbushnell commented 5 years ago

Fixes #17

ttempleton commented 5 years ago

Hi @aaronbushnell, thanks for the pull request!

I've just tried out the changes and it doesn't seem to save new or updated labels for me, but if I pull $this->_bindEvent() back out of the event, everything seems to be fine. I think that should be okay since nothing in $this->_bindEvent() needs to check whether the user is logged in -- can you please confirm whether everything still works fine in your case with that change?

aaronbushnell commented 5 years ago

Good catch! I made that tweak, @ttempleton!

ttempleton commented 5 years ago

Awesome, thanks!