search

spicywebau / craft-fieldlabels

Override Craft CMS field labels and instructions in the field layout designer
MIT License
123 stars 9 forks source link

Labels are only applied on first entry type #44

Closed gglnx closed 4 years ago

gglnx commented 4 years ago

Description

I have a section with multiple entry types. The field labels are only applied to the first entry type (lowest ID).

Steps to reproduce

  1. Create a section with two entry types with different field layouts.
  2. Override field labels in both entry types.
  3. Check entries for both types.

Other information

pvldigital commented 4 years ago

Hi @gglnx,

I've testing with the provided steps but I'm unable to replicate the issue. Have you noticed any errors in the console or web.log relating to field labels?

gglnx commented 4 years ago

It was my error. I did hide the entryType field used by the JS to determinante the entry type ID: https://github.com/spicywebau/craft-fieldlabels/blob/0936e064f1a4fbd33b1985cbd07603b3de11ab28/src/resources/js/Widgets.js#L166