search

spicywebau / craft-fieldlabels

Override Craft CMS field labels and instructions in the field layout designer
MIT License
123 stars 9 forks source link

Incompatible with PHP 5.3 #7

Closed certainlyakey closed 5 years ago

certainlyakey commented 8 years ago

My server environment has PHP 5.3 installed. The plugin gave me the Parse error: syntax error, unexpected '[' in .../plugins/relabel/RelabelPlugin.php on line 192 error. Could it be easily made compatible? Two Craft CMS plugins recently (CategorySources and CPFieldLinks) had the same problem, and it seems all that has been required was to change array syntax (see here).

benjamminf commented 8 years ago

Honestly, I'm not sure. I never code for 5.3, as I tend to take advantage of things like array dereferencing and shorthand array syntax. Looking at http://php.net/manual/en/migration54.new-features.php it might only be that particular line preventing 5.3 compatibility. But I have no plans to officially support 5.3, and I encourage you to upgrade if you're able to as Craft 3 is also dropping support.

That said, if you want to make the change yourself and see if it works on 5.3, I'll be happy to merge it into the plugin.

ttempleton commented 5 years ago

Closing this issue due to Relabel for Craft 2 being retired and Field Labels' inability to support PHP 5.3 given Craft 3's requirement of PHP 7.0+.