search

spicywebau / craft-neo

A Matrix-like field type for Craft CMS that uses existing fields
Other
402 stars 63 forks source link

Transfering data between locale when deleting a locale #79

Open mrksmts opened 7 years ago

mrksmts commented 7 years ago

When you delete a locale you get the option to transfer the data from the old locale to a different locale.

Instead of moving the data to the different locale the data gets deleted. Probably done by deleteSiteLocale() on line 334 of LocalizationService

Might relate to #77

benjamminf commented 7 years ago

Been something I've been working on for a while now – turns out locales are tricky 😅

benjamminf commented 7 years ago

After comparing the behaviour to the Matrix field, it seems that Neo's behaviour is identical. To be honest, I'm not entirely sure what you should expect when transferring locale data. Should any data in the locale being overwritten be completely replaced with the deleted one? Or should only Neo fields that are empty have data copied over to them?

I may need to discuss this with somebody who knows a bit more about locales than myself.