spicywebau / craft-neo

A Matrix-like field type for Craft CMS that uses existing fields
Other
403 stars 63 forks source link

Exponential increase of blocks when adding an existing entry to another site #870

Closed ttempleton closed 3 months ago

ttempleton commented 3 months ago

It seems that a new issue has surfaced after the recent fix was pushed. I'm not sure if it's related to the fix or if it's a separate issue. When adding an existing entry to another site and saving it, the blocks appear to be recursively multiplied, resulting in an exponential increase (I guess per removal of the entry for the site, an extra block is added). This problem doesn't occur with new entries. However, it's reproducible with new entries by adding the entry to another site, then removing it for that particular site, and finally adding it again. Please see the video for reference.

Originally posted by @bavodeclercq in https://github.com/spicywebau/craft-neo/issues/863#issuecomment-2017590437

ttempleton commented 3 months ago

I'm unable to reproduce this - @bavodeclercq if possible, could you please send your composer files and database backup to plugins@spicyweb.com.au, and we'll have a look.

bavodeclercq commented 3 months ago

I'm unable to reproduce this - @bavodeclercq if possible, could you please send your composer files and database backup to plugins@spicyweb.com.au, and we'll have a look.

Hi, I've sent the requested files.

BorisWRLB commented 3 months ago

@ttempleton Did you eventually manage to recreate the issue?

For me the issue occurs when deleting an entry for a site, on an entry that exists for multiple sites. Adjusting the entry's neo field in the site that is remaining. Then re-adding the entry for another site, the same way the original issue described.

Version: 4.0.8

ttempleton commented 3 months ago

Thanks for sending the files @bavodeclercq - fixed now in 4.1.0.

@BorisWRLB please also upgrade to 4.1.0 and let me know if the issue persists for you.

BorisWRLB commented 2 months ago

@ttempleton

@BorisWRLB please also upgrade to 4.1.0 and let me know if the issue persists for you.

It seems to have fixed the issues I had, thank you for the quick fix.