IO write should return the number of bytes written

spider-gazelle / bindata

BinData - Parsing Binary Data in Crystal Lang

MIT License

48 stars 5 forks source link

IO write should return the number of bytes written #6

Closed stakach closed 4 years ago

stakach commented 4 years ago

as per the changes in crystal 0.35.0 currently we are returning 0 as a stop gap

Blacksmoke16 commented 4 years ago

@stakach This needs revisited due to the release of 0.35.1.

Showing last frame. Use --error-trace for full trace.

In lib/bindata/src/bindata/bitfield.cr:162:27

162 | def write(io, format) : Int64
^
Error: method must return Int64 but it is returning Nil

#write returns nil now, making it incompatible with the return type restriction.

stakach commented 4 years ago

@Blacksmoke16 thanks for letting me know released v1.5.5 which is compatible with both 0.35.0 and 0.35.1