search

spider-gazelle / crystal-ldap

a Crystal lang LDAP client
MIT License
18 stars 1 forks source link

Support for Crystal 1.0.0 #5

Closed plambert closed 3 years ago

plambert commented 3 years ago

What needs to be done to be able to use this shard with Crystal 1.0.0 without the --ignore-crystal-version flag?

Does it require testing? Or just a metadata update?

stakach commented 3 years ago

should already work with crystal 1.0.0 without needing --ignore-crystal-version

plambert commented 3 years ago

Then why was https://github.com/spider-gazelle/crystal-ldap/commit/e46686aaced1398dfd85509a19f96ce920bff288 added?

On my system shards update gives me:

- `crystal (>= 0.36.1)` required by `ldap 0.9.1`

My understanding is that >=0.36.1 doesn't mean "all future versions for eternity" but "all minor and patch versions above this one." 1.0.0 does not satisfy >=0.36.1. Am I wrong?

plambert commented 3 years ago

No... you're right, ignore me. Removing all my other dependencies, it installs fine, so the problem has to be somewhere else. I'll track it down.

stakach commented 3 years ago

The trick is to run shards update --ignore-crystal-version and then it should give you a list of the possibly incompatible shards at the end of the update

i.e. Shard "CrystalEmail" may be incompatible with Crystal 1.0.0