search

spider-gazelle / rethinkdb-orm

RethinkDB ORM for Crystal lang
MIT License
24 stars 0 forks source link

future.cr -> async #15

Closed watzon closed 2 years ago

watzon commented 3 years ago

Closes #7

Figured I'd go ahead and PR this and see how you feel about it. As mentioned in #7, my Async::Future is a bit more powerful than the old Future that use to be in the standard library. I've tried to take inspiration from both Python's asyncio and JavaScript's promises.

caspiano commented 3 years ago

The team that maintains this library has its own asynchronous abstraction of Fibers as Promise. We've been using that library in production for a while now and I currently don't have the bandwidth to review your library. I'll merge once I have had time to dig through your library.

watzon commented 3 years ago

Sounds good man, just trying to help close some issues while I also create some new ones

watzon commented 3 years ago

Tagged it wrong initially so the build failed, but it should pass now