Closed ninjadev64 closed 2 months ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 7bc4a4816de5d7c3b786cde0f6ce9eaf5b131a8b |
Hi thanks for creating PR.
The changes to how we set the environment variables makes sense. But can you recreate the PR while removing the changes to package-lock.json
? This shouldn't be mixed in this PR and also I am not sure about the issues related to dependencies.
@spider-hand Done :+1: (but you should definitely run npm audit fix
at least, as npm is reporting 6 moderate and 2 severe vulnerabilities)
Looks good. Thanks you @ninjadev64 !
I was experiencing an issue where the computed
https://projectid.firebaseio.com
database URL was different to the actual database URL that I received from the Firebase console (https://projectid-default-rtdb.location.firebasedatabase.app
), resulting in me not being able to play multiplayer games (as Firebase failed to initialise), so I made this project read all of thefirebaseConfig
values from the .env file.Edit: I also ran
npm update
as it seemed like it hadn't been in a long time, which should hopefully fix some bugs and security issues.