search

spider-hand / GeoguessMaster

Free geoguess game
https://geoguessmaster.net
MIT License
158 stars 161 forks source link

Improvements to the rendering of map markers #74

Closed ninjadev64 closed 2 months ago

ninjadev64 commented 2 months ago

This PR implements using different glyphs and colours to better distinguish map markers. A flag is used to represent the actual location of the Street View image, a circle for your guess, and a person image for the guess of another player. A colour is generated for each player based on their player ID.

This PR also migrates to the new Advanced Markers API from the deprecated google.maps.Marker.

Singleplayer

Screenshot from 2024-06-23 20-33-25

Multiplayer

Screenshot from 2024-06-23 20-36-49

netlify[bot] commented 2 months ago

Deploy request for elated-elion-cc4c99 pending review.

Visit the deploys page to approve it

Name Link
Latest commit b7f0eabaac1104621a829e842d70f99ec3c68d24
ninjadev64 commented 2 months ago

I just realised I added a redundant prop to MapComponent, so I marked this as draft until I fix it. (I also want to make the polylines dashed.)

spider-hand commented 2 months ago

This is more like a feature by itself. I know there are some things that could be improved but I don't update this repo for new features actively now. I think you could open an issue first if there is a feature you want to have in this repo but again I don't update this repo that much.

ninjadev64 commented 2 months ago

How is this a new feature? It's impossible to tell what's what when all the markers are identical. If basic stuff isn't being accepted into this repo then I'll be maintaining a fork instead of contributing upstream.

ninjadev64 commented 2 months ago

I fixed the redundancy and made the lines dashed. Screenshot from 2024-06-24 18-19-56 Screenshot from 2024-06-24 18-24-30

I'd be interested to know why you aren't accepting new features. I understand why you might not have time to add them yourself, but why don't you accept contributions for them? Besides, I wouldn't consider this an extra feature, more like something that needs to be added for the game to be playable, especially in multiplayer.

If you don't want to merge this PR, please close it and I will maintain a fork separately.

spider-hand commented 2 months ago

@ninjadev64 For things that provide new UIUX, I cannot accept stuff immediately. For example, maybe I could just create my custom marker image or use other icons on the marker instead. I need to think about how I can instruct users who want to self host this game to use custom marker. (Or is it really ok to just use DEMO_MAP_ID for them?) There are a lot of ways to achieve something and I need to take time to consider it.

ninjadev64 commented 2 months ago

I need to think about how I can instruct users who want to self host this game to use custom marker.

They don't need to do anything for this feature to work.

Anyway, in that case, I'll be forking the project and closing this PR.