spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
505 stars 72 forks source link

add link-local IP to veth0 for istio #3588

Closed cyclinder closed 1 week ago

cyclinder commented 2 weeks ago

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

The iptables redirect module uses the IP address of the incoming interface as the dst to modify the packet, but if the interface is not configured with an IP address, the packet will be dropped.

NOTE: this is for istio sidecar

Which issue(s) this PR fixes:

Fixes https://github.com/spidernet-io/spiderpool/issues/3568

Special notes for your reviewer:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.16%. Comparing base (b6e4746) to head (b91c9dd).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3588/graphs/tree.svg?width=650&height=150&src=pr&token=YKXY2E4Q8G&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) ```diff @@ Coverage Diff @@ ## main #3588 +/- ## ======================================= Coverage 81.16% 81.16% ======================================= Files 50 50 Lines 4391 4391 ======================================= Hits 3564 3564 Misses 670 670 Partials 157 157 ``` | [Flag](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | `81.16% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#carryforward-flags-in-the-pull-request-comment) to find out more.
weizhoublue commented 2 weeks ago

cherry pick ?

weizhoublue commented 2 weeks ago

@ty-dc CI failed, is it caused by the upgrade CI ?

ty-dc commented 2 weeks ago

@ty-dc CI failed, is it caused by the upgrade CI ?

no rebase main