search

spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
505 stars 72 forks source link

RBAC: rebase pull 3522 #3603

Closed cyclinder closed 2 weeks ago

cyclinder commented 2 weeks ago

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

Error: The Artifacts is out of date! Please run 'make manifests'.
make: *** [Makefile:170: manifests-verify] Error 1
error, failed to check Kubebuilder SDK and yaml

the rbac files are auto-generated by controller-gen, we don't edit it. Or we can't pass the SDK check. so rebase https://github.com/spidernet-io/spiderpool/pull/3522.

Which issue(s) this PR fixes:

Fixes https://github.com/spidernet-io/spiderpool/actions/runs/9544364352/job/26303312400?pr=3584

Special notes for your reviewer:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.31%. Comparing base (f4d26b6) to head (6c4d315).

:exclamation: Current head 6c4d315 differs from pull request most recent head ff1e81c

Please upload reports for the commit ff1e81c to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3603/graphs/tree.svg?width=650&height=150&src=pr&token=YKXY2E4Q8G&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) ```diff @@ Coverage Diff @@ ## main #3603 +/- ## ======================================= Coverage 81.31% 81.31% ======================================= Files 50 50 Lines 4352 4352 ======================================= Hits 3539 3539 Misses 661 661 Partials 152 152 ``` | [Flag](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3603/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | `81.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#carryforward-flags-in-the-pull-request-comment) to find out more.