search

spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
523 stars 76 forks source link

add link-local IP to veth0 for istio #3623

Closed weizhoublue closed 3 months ago

weizhoublue commented 3 months ago

robot cherry pick PR https://github.com/spidernet-io/spiderpool/pull/3588 from cyclinder,to branch release-v0.9, action https://github.com/spidernet-io/spiderpool/actions/runs/9609000879 , commits 13c95f09d9040352c02750cb8d8d970feea319f5

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.48%. Comparing base (f4809e8) to head (d7fa0e4).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3623/graphs/tree.svg?width=650&height=150&src=pr&token=YKXY2E4Q8G&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) ```diff @@ Coverage Diff @@ ## release-v0.9 #3623 +/- ## ============================================= Coverage 81.48% 81.48% ============================================= Files 50 50 Lines 4338 4338 ============================================= Hits 3535 3535 Misses 641 641 Partials 162 162 ``` | [Flag](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/3623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | `81.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#carryforward-flags-in-the-pull-request-comment) to find out more.
weizhoublue commented 3 months ago

@ty-dc ci

ty-dc commented 3 months ago

The code merged into release-v0.9 triggers the pull_request_target to use the image of the main branch.

weizhoublue commented 3 months ago

https://github.com/spidernet-io/spiderpool/actions/runs/9609003755/job/26502881762?pr=3623

encountered an failed case never happened

     fail to run a pod when IP resource of an ippool is exhausted and an IP who is set in excludeIPs field of ippool, should not be assigned to a pod [E00008, S00002]
ty-dc commented 3 months ago 
Warning  FailedCreatePodSandBox  4m38s (x17 over 8m8s)  kubelet            (combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "915253528605f96a4db27301569495040e6e5bfd93e55e643aff6b04711acd4e": plugin type="multus" name="multus-cni-network" failed (add): [ns187-858559962/deploy187-858549683-5b4569f6dc-qrqk7/7a54422a-5a39-4650-8e1d-07d5d67ab318:macvlan-vlan0]: error adding container to network "macvlan-vlan0": spiderpool IP allocation error: [POST /ipam/ip][500] postIpamIpFailure  failed to allocate IP addresses in standard mode: it's invalid to use 'ipam.spidernet.io/subnets' or 'ipam.spidernet.io/subnet' annotation when Auto-Pool feature is disabled

The upgrade-ci command in cherry-pick fails due to an image usage error.

Now, I rebase release-v0.9, and we will observe CI later.