search

spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
523 stars 76 forks source link

The ipam.spidersubnet in the chart was changed to ipam.spiderSubnet, causing the upgrade to fail #4050

Open github-actions[bot] opened 2 weeks ago

github-actions[bot] commented 2 weeks ago

action url: https://github.com/spidernet-io/spiderpool/actions/runs/10799804934

ty-dc commented 2 weeks ago 
ALL_IMAGES: ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.3 ghcr.io/spidernet-io/spiderpool/spiderpool-plugins:82659d90cae0d6a5169eac2869e47c989932d775 spiderpool-agent-race:main spiderpool-controller-race:main  
ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.3
Image: "ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.3" with ID "sha256:c0e8690ae66a1855684cfe1295b3916d63a28918a78cf483eb6ad9dd018da415" found to be already present on all nodes.
ghcr.io/spidernet-io/spiderpool/spiderpool-plugins:82659d90cae0d6a5169eac2869e47c989932d775
Image: "ghcr.io/spidernet-io/spiderpool/spiderpool-plugins:82659d90cae0d6a5169eac2869e47c989932d775" with ID "sha256:ec4a0891f85ae46d1defbaf8baecd6b6ae03c210b0124b9eb648cc035d69b072" found to be already present on all nodes.
spiderpool-agent-race:main
Image: "spiderpool-agent-race:main" with ID "sha256:31ca59e3f1724845ec940e29177067b8bb354b946129d4f540916710dce16fc3" not yet present on node "spiderpool0910202609-control-plane", loading...
Image: "spiderpool-agent-race:main" with ID "sha256:31ca59e3f1724845ec940e29177067b8bb354b946129d4f540916710dce16fc3" not yet present on node "spiderpool0910202609-worker", loading...
spiderpool-controller-race:main
Image: "spiderpool-controller-race:main" with ID "sha256:b2e7e9e06a38bda1c[214](https://github.com/spidernet-io/spiderpool/actions/runs/10799804934/job/29956732433#step:17:215)84b0d5513d5cde264c8aa0799c1edc8cc6d1068e2745" not yet present on node "spiderpool0910202609-control-plane", loading...
Image: "spiderpool-controller-race:main" with ID "sha256:b2e7e9e06a38bda1c21484b0d5513d5cde264c8aa0799c1edc8cc6d1068e2745" not yet present on node "spiderpool0910202609-worker", loading...
upgrade spiderpool with image spiderpool-agent-race:main and spiderpool-controller-race:main 
+ helm --kubeconfig /home/runner/work/spiderpool/spiderpool/test/.cluster/spiderpool0910202609/.kube/config upgrade spiderpool /home/runner/work/spiderpool/spiderpool/charts/spiderpool --set spiderpoolController.replicas=1 --set multus.multusCNI.defaultCniCRName=macvlan-vlan0 --set spiderpoolAgent.image.registry= --set spiderpoolAgent.image.repository=spiderpool-agent-race --set spiderpoolAgent.image.tag=main --set spiderpoolController.image.registry= --set spiderpoolController.image.repository=spiderpool-controller-race --set spiderpoolController.image.tag=main --set spiderpoolInit.image.registry= --set spiderpoolInit.image.repository=spiderpool-controller-race --set spiderpoolInit.image.tag=main --set multus.multusCNI.uninstall=false -n kube-system --debug --reuse-values
upgrade.go:158: [debug] preparing upgrade for spiderpool
upgrade.go:550: [debug] reusing the old release's values
Error: UPGRADE FAILED: template: spiderpool/templates/pod.yaml:60:22: executing "spiderpool/templates/pod.yaml" at <.Values.ipam.spiderSubnet.enable>: nil pointer evaluating interface {}.enable
helm.go:84: [debug] template: spiderpool/templates/pod.yaml:60:22: executing "spiderpool/templates/pod.yaml" at <.Values.ipam.spiderSubnet.enable>: nil pointer evaluating interface {}.enable
UPGRADE FAILED
main.newUpgradeCmd.func2
    helm.sh/helm/v3/cmd/helm/upgrade.go:240
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/cobra@v1.8.0/command.go:983
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/cobra@v1.8.0/command.go:1115
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/cobra@v1.8.0/command.go:1039
main.main
    helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
    runtime/proc.go:271
runtime.goexit
    runtime/asm_amd64.s:1695
make[2]: *** [Makefile:429: helm_upgrade_spiderpool] Error 1
make[2]: Leaving directory '/home/runner/work/spiderpool/spiderpool/test'
make[1]: *** [Makefile:424: upgrade_spiderpool] Error 2
make[1]: Leaving directory '/home/runner/work/spiderpool/spiderpool/test'
make: *** [Makefile:437: upgrade_e2e_spiderpool] Error 2
failed to upgrade spiderpool from v1.0.0-rc1 to main
ty-dc commented 1 week ago

In PR #https://github.com/spidernet-io/spiderpool/pull/3772/files, ipam.spidersubnet.enable was changed to ipam.spiderSubnet.enable, which caused the upgrade to fail when using the --reuse-value parameter