search

spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
539 stars 75 forks source link

fix: same-name conflict check specified by multus.spidernet.io/cr-name #4168

Closed ty-dc closed 1 month ago

ty-dc commented 1 month ago

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4167 Fixed #4183 Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.34%. Comparing base (50dcb53) to head (55fba7e). Report is 12 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4168/graphs/tree.svg?width=650&height=150&src=pr&token=YKXY2E4Q8G&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) ```diff @@ Coverage Diff @@ ## main #4168 +/- ## ========================================== - Coverage 80.85% 80.34% -0.52% ========================================== Files 51 51 Lines 4519 5637 +1118 ========================================== + Hits 3654 4529 +875 - Misses 699 941 +242 - Partials 166 167 +1 ``` | [Flag](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4168/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4168/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | `80.34% <ø> (-0.52%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#carryforward-flags-in-the-pull-request-comment) to find out more. [see 49 files with indirect coverage changes](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4168/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)