spidernet-io / spiderpool

Underlay and RDMA network solution of the Kubernetes, for bare metal, VM and any public cloud
https://spidernet-io.github.io/spiderpool/
Apache License 2.0
538 stars 75 forks source link

podResourceInject: annotate a group of spidermultusconfig without labels #4258

Closed cyclinder closed 2 weeks ago

cyclinder commented 3 weeks ago

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

  1. annotate a group of spidermultusconfigs rather than label.
  2. Do not validate a group of spidermultusconfigs with same cniType.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (646ed6d) to head (7fdd696). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/podmanager/utils.go 85.71% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258/graphs/tree.svg?width=650&height=150&src=pr&token=YKXY2E4Q8G&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) ```diff @@ Coverage Diff @@ ## main #4258 +/- ## ========================================== + Coverage 79.26% 79.55% +0.28% ========================================== Files 53 53 Lines 6290 6252 -38 ========================================== - Hits 4986 4974 -12 + Misses 1110 1085 -25 + Partials 194 193 -1 ``` | [Flag](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | `79.55% <85.71%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io) | Coverage Δ | | |---|---|---| | [pkg/podmanager/utils.go](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258?src=pr&el=tree&filepath=pkg%2Fpodmanager%2Futils.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io#diff-cGtnL3BvZG1hbmFnZXIvdXRpbHMuZ28=) | `74.03% <85.71%> (+7.77%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/spidernet-io/spiderpool/pull/4258/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spidernet-io)