search

spiegela / react-relay-modern-starter-kit

Expanded of Relay Modern Starter Kit with ReactMD and Authentication
MIT License
9 stars 0 forks source link

Why are you using graphql queries as opposed to relay.QL? #1

Open workteam123 opened 6 years ago

workteam123 commented 6 years ago

relay.QL is native to relay modern so why did you choose this one? second - multiple routes would give a better example. Thank you for your work and dont take this as a criticism - its just an idea. Gary

devdlabs commented 6 years ago

Relay.QL looks like classic style https://facebook.github.io/relay/docs/api-reference-relay-ql.html

spiegela commented 6 years ago

@workteam123 I think in modern the correct syntax is Relay.graphql -- since those routes didn't need to import all of Relay, you can just import graphql like so:

import {graphql} from 'react-relay'

This seems to be correct, based on examples that I've read, but I'm open to what differences are, and if I should change it.

Also, on the question of routing, I've just pushed another branch with Auth0 and Found-Relay integration -- restricted routes and such. I had set this project aside for a bit since my day job got busy, so I'm still working out some issues with it.

Also, I'll post the Absinthe-based backend that I'm prepping to go with this. As I add authentication support, it'll cease being compatible with other Relay-Modern starter kit backends.

workteam123 commented 6 years ago

Thanks for that - I beleive you are right. Absinthe seems to have a very restrictive license. Thanks again for your work. Gary

On 28 October 2017 at 20:36, Aaron Spiegel notifications@github.com wrote:

@workteam123 https://github.com/workteam123 I think in modern the correct syntax is Relay.graphql -- since those routes didn't need to import all of Relay, you can just import graphql like so:

import {graphql} from 'react-relay'

This seems to be correct, based on examples that I've read, but I'm open to what differences are, and if I should change it.

Also, on the question of routing, I've just pushed another branch https://github.com/spiegela/react-relay-modern-starter-kit/tree/auth0 with Auth0 https://auth0.com and Found-Relay https://github.com/4Catalyzer/found-relay integration -- restricted routes and such. I had set this project aside for a bit since my day job got busy, so I'm still working out some issues with it.

Also, I'll post the Absinthe https://absinthe-graphql.org-based backend that I'm prepping to go with this. As I add authentication support, it'll cease being compatible with other Relay-Modern starter kit backends.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spiegela/react-relay-modern-starter-kit/issues/1#issuecomment-340214710, or mute the thread https://github.com/notifications/unsubscribe-auth/AJJY5H-kdayYt2ULyqdpETY9f05RK4uNks5sw4IsgaJpZM4QIxCD .

workteam123 commented 6 years ago

Hi can you post your server schema please (with resolvers) Gary

spiegela commented 6 years ago

Sure. I'll post the Absinthe project, and I'll go ahead and commit the cached scheme to this project as well.

FYI, Absinthe is licensed as MIT, which is really very permissive: https://github.com/absinthe-graphql/absinthe/blob/master/README.md

workteam123 commented 6 years ago

Aaron - My mistake - at the bottom of the absinthe homepage I clicked on licence but it related to the background image of the homepage not the code! Thanks for the schema. Gary

On 29 October 2017 at 02:27, Aaron Spiegel notifications@github.com wrote:

Sure. I'll post the Absinthe project, and I'll go ahead and commit the cached scheme to this project as well.

FYI, Absinthe is licensed as MIT, which is really very permissive: https://github.com/absinthe-graphql/absinthe/blob/master/README.md

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spiegela/react-relay-modern-starter-kit/issues/1#issuecomment-340232968, or mute the thread https://github.com/notifications/unsubscribe-auth/AJJY5Ey_39WIr5bZn7F8Osy4MVMD1IWaks5sw-KmgaJpZM4QIxCD .