search

spiegelp / MaterialDesignExtensions

Material Design Extensions is based on Material Design in XAML Toolkit to provide additional controls and features for WPF apps
https://spiegelp.github.io/MaterialDesignExtensions/
MIT License
754 stars 122 forks source link

Rewrite on .NET Core 3.1 #65

Closed Gigas002 closed 4 years ago

Gigas002 commented 4 years ago

I've rewritten all projects on .net core 3.1 (LTS) with very minor improvements (I targeted not to change the code inside as much as possible). I've also removed Pri.LongPath package, as it was noted that it isn't needod on net core 3.0 or higher.

spiegelp commented 4 years ago

@Gigas002 Thank you for your efforts but I already have a working .NET Core 3 setup on a separate branch (see here) since Monday. I didn't merge that branch yet because I want to migrate all projects first and want to be sure that everything still work as expected.

Gigas002 commented 4 years ago

@spiegelp Ah, I didn't see that branch. Sorry for wasting the time, I suppose that PR can now be closed. And thanks for pointing on my mistakes, I'll try better next time making PR.

spiegelp commented 4 years ago

@Gigas002 It was just an unlucky timing and my habit for using new branches for critical code changes. It's not a waste of time, because I also trained my skills by going deeper into technical details and checking foreign code changes. I hope you also learned something by porting a foreign library to .NET Core.

I will close this PR without merging it. However, I would like to thank you for your efforts to contribute to Material Design Extensions.

PS: Check out the latest pre-release with .NET Core 3 support.