getChildren() is used for nodes, should only be used for data items

spiermar / d3-flame-graph

A D3.js plugin that produces flame graphs from hierarchical data.

Apache License 2.0

890 stars 119 forks source link

getChildren() is used for nodes, should only be used for data items #118

Open wonder-mice opened 6 years ago

wonder-mice commented 6 years ago

Currently getChildren() is used inconsistently. For d3 nodes must use node.children directly - faster and more correct. getChildren() must only be used for hierarchy() calls (maybe there are some other use cases, but mostly it).

wonder-mice commented 6 years ago

I'm working on it.