search

spiermar / d3-flame-graph

A D3.js plugin that produces flame graphs from hierarchical data.
Apache License 2.0
890 stars 119 forks source link

jsdelivr.net does not have latest versions #162

Closed alexbozhenko closed 3 years ago

alexbozhenko commented 4 years ago

https://cdn.jsdelivr.net/gh/spiermar/d3-flame-graph@4.0.6/ and other versions after 2.1.4 are missing "dist" directory.

So the exmaple from README.md that reverences files at https://cdn.jsdelivr.net/gh/spiermar/d3-flame-graph@4.0.0/dist/

is broken. (4.0.0. tag is also missing all toghether)

Is it possible to generate "dist" for all those recent versions?

alexbozhenko commented 3 years ago

@spiermar Do you think you can resume publishing the "dist" directory?

spiermar commented 3 years ago

You're right. We stopped publishing the dist directory. It was causing a few problems, so I'll have to think of a better way to distribute it on jsdelivr and update the documentation

thegreystone commented 3 years ago

This is a bit of a pickle for OpenJDK Mission Control as well. We need to upgrade to a more recent version, but can't find where to pick it up: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.flameview/pom.xml#L68

spiermar commented 3 years ago

Yes, saw that. At this point, I believe the best approach is a GH action or Travis job to publish new versions. I'll try to get to that shortly.

thegreystone commented 3 years ago

Looking forward to it! :) Let me know if there is something anyone of us can do to help.

spiermar commented 3 years ago

On my to do list for this week. Should be something simple, just need to block some time for it.

thegreystone commented 3 years ago

Pretty please? :)

spiermar commented 3 years ago

Ok, so ended up not having to do anything. jsdelivr can host npm files too, and npm includes the dist folder.

https://cdn.jsdelivr.net/npm/d3-flame-graph@4.0.6/dist/d3-flamegraph.min.js

I'll update the readme and also create a GH action to auto-publish new tags to npm.