Add resource limits for upgrade and delete hook batch jobs

spiffe / helm-charts-hardened

Apache License 2.0

17 stars 31 forks source link

Add resource limits for upgrade and delete hook batch jobs #322

Closed anhpatel closed 4 months ago

kfox1111 commented 5 months ago

+1 to a global setting for these. Switching it to only be global though may break some existing users.

Maybe use the sprig mergeOverwrite function to support both? (https://masterminds.github.io/sprig/dicts.html)

anhpatel commented 5 months ago

@kfox1111 These global resource limits are only being set for all batch related containers. Which other case of resource limits do you think this will conflict with?

kfox1111 commented 5 months ago

Oh. I guess I saw a commit wiz by (https://github.com/spiffe/helm-charts-hardened/pull/322/commits/d099e572be8de5548cf276b34e1a9e26925bb61c) and thought it was changing existing code. Never mind my previous comment. Sorry for the confusion.

edwbuck commented 4 months ago

Added to 0.22.0 as it seems mostly ready (by Kevin's appraisal) and 0.21.0 is already late for its scheduled release date.

kfox1111 commented 4 months ago

We can't write to this repo, and we haven't heard back from the original author in a long time. Continuing development in https://github.com/spiffe/helm-charts-hardened/pull/366 instead since we can write to it there.