search

spiffe / helm-charts-hardened

Apache License 2.0
17 stars 31 forks source link

incorrect versions in subcharts #339

Open drewwells opened 5 months ago

drewwells commented 5 months ago

From looking at the code, this may be by design due to the subcharting strategy. However, helm.sh/chart: is reporting the incorrect version for all the charts. 

❯ helm template -n spire-server spire spire --repo https://spiffe.github.io/helm-charts-hardened/ --version 0.20.0 | grep 'helm.sh/chart' | sort | uniq                                        
    helm.sh/chart: spiffe-csi-driver-0.1.0
    helm.sh/chart: spiffe-oidc-discovery-provider-0.1.0
    helm.sh/chart: spire-agent-0.1.0
        helm.sh/chart: spire-server-0.1.0
    helm.sh/chart: spire-server-0.1.0

I generally track subcharts with independent versions. For instance, a release that only updated oidc would have no impact on spire-server subchart and not cycle all the spire-agents.

Changing the versions probably will require dropping the versions in the relative imports. I'm not sure if that was addressing something but the relative imports should make versions unnecessary https://github.com/spiffe/helm-charts-hardened/blob/main/charts/spire/Chart.yaml#L27

faisal-memon commented 5 months ago

We discussed this in the weekly sync meeting today. When we move to having multiple root level charts (https://github.com/spiffe/helm-charts-hardened/issues/11) then we'll have proper versioning for these charts as a result.