search

spiffe / spiffe-csi

Container Storage Interface components for SPIFFE
Apache License 2.0
52 stars 21 forks source link

Develop a unit test suite #2

Open evan2645 opened 2 years ago

evan2645 commented 2 years ago

The codebase is very small, but there are still some opportunities to cover some of the functions by unit test. Cover the functions that make sense, making minor modifications to the code if necessary.

evan2645 commented 2 years ago

It would be great if we could just stick to go stdlib for this

azdagron commented 2 years ago

It would be great if we could just stick to go stdlib for this

Does this mean not pulling in something that implements convenient assertions (e.g. github.com/stretchr/testify)? or something else?

evan2645 commented 2 years ago

Does this mean not pulling in something that implements convenient assertions (e.g. github.com/stretchr/testify)?

This was my intention, but it's just a preference :)

azdagron commented 2 years ago

That seems fine. The unit-tests should be small enough, this shouldn't cause too much issue. Keepin' it simple!