spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
43 stars 40 forks source link

Update Config Files with SPIRE Agent Default Socket Path and Fix `README.md` Table Formatting #102

Closed maxlambrecht closed 8 months ago

maxlambrecht commented 9 months ago

This PR includes updates to all configuration files, changing the SPIRE agent socket path to the default "/tmp/spire-agent/public/api.sock". Additionally, adjustments have been made to fix the formatting of the table in the README.md file.

faisal-memon commented 9 months ago

@maxlambrecht Thanks for submitting this. Will it close https://github.com/spiffe/spiffe-helper/issues/36?

maxlambrecht commented 8 months ago

@maxlambrecht Thanks for submitting this. Will it close #36?

I'm not sure, this PR aligns the socket path in config files and docs with SPIRE's default, but it overlooks incorporating support for the standard environment variable to define that path.

faisal-memon commented 8 months ago

@maxlambrecht can you rebase?