search

spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
40 stars 39 forks source link

Add ability to exit on successful retrieval of JWT SVID #121

Open keeganwitt opened 7 months ago

kfox1111 commented 6 months ago

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

keeganwitt commented 6 months ago

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

Yes, I think so. It's confusing that there's not parity here.

keeganwitt commented 6 months ago

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

kfox1111 commented 6 months ago

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

keeganwitt commented 6 months ago

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

Yea, I guess it should signal once when all the JWTs are fetched, not each time. Dunno why I didn't think of that.