search

spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
40 stars 39 forks source link

add missing files to fix docker build #154

Closed gflarity closed 2 months ago

gflarity commented 2 months ago

Looks like commit eb7a20 broke the docker build (via theDockerfile). Previously only main.go was COPY'd in the docker file.

Fix is simple, just COPY the whole cmd/spiffe-helper directory rather than just the main.go.

Looks like the nightly builds have been failing. One suggestion might to add building the docker image to the pr_build tests. I can take a stab at this if desired, I'd mostly just cut and paste from the nightly build minus the pushing.

Thanks, Geoff

faisal-memon commented 2 months ago

One suggestion might to add building the docker image to the pr_build tests. I can take a stab at this if desired, I'd mostly just cut and paste from the nightly build minus the pushing.

That would be a great addition if you have the time for it.

gflarity commented 2 months ago

One suggestion might to add building the docker image to the pr_build tests. I can take a stab at this if desired, I'd mostly just cut and paste from the nightly build minus the pushing.

That would be a great addition if you have the time for it.

Thanks @gflarity . Just need to fix up the DCO and then we can merge this.

Done!