spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
39 stars 39 forks source link

SPIFFE Helper releases #165

Open MarcosDY opened 1 month ago

MarcosDY commented 1 month ago

Add automation to create images when releasing spiffe-helper,

Acceptance criteria:

Optional:

gflarity commented 1 month ago

Not sure how this typically managed, but seems like it should be possible: 1) trigger a github workflow when there's a new tag. Say of the format v#.#.# (like v1.0.0) 2) create a new release via a github workflow: https://trstringer.com/github-actions-create-release-upload-artifacts/

I'll investigate further (see how it's done in other spiffe projects) and submit a PR if a maintainer can give the nod that it's likely to be accepted.

Edit: Something like: https://github.com/spiffe/spire/blob/main/.github/workflows/release_build.yaml

MarcosDY commented 1 month ago

You can follow the same structure we use for SPIRE or spire-controller-manager I suggest something more similar ton controller manager, because SPIRE is more complex

keeganwitt commented 1 month ago

Isn't there already a workflow that matches the spire-controller-manager (https://github.com/spiffe/spiffe-helper/blob/main/.github/workflows/release_build.yaml matching https://github.com/spiffe/spire-controller-manager/blob/main/.github/workflows/release_build.yaml)?

gflarity commented 3 weeks ago

Isn't there already a workflow that matches the spire-controller-manager (https://github.com/spiffe/spiffe-helper/blob/main/.github/workflows/release_build.yaml matching https://github.com/spiffe/spire-controller-manager/blob/main/.github/workflows/release_build.yaml)?

I'll take a look. Who's the current maintainer who would actually create a release?

keeganwitt commented 3 weeks ago

I can't see the member list, but I know @MarcosDY can and I think @faisal-memon did the last release.

gflarity commented 3 weeks ago

:+1: I'm swamped but this is still on my todo list. Hopefully take a look and then ping them next week.