search

spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
43 stars 40 forks source link

Update helper to use the new workload API #5

Closed drrt closed 1 year ago

omerlh commented 5 years ago

The new API also supports JWT tokens, correct?

faisal-memon commented 4 years ago

I took a first pass at this but I had to use a global variable because I couldn't find a way to push the sidecar object through the new watcher interface. Does anyone know a better way?

My changes (not PR worthy): https://github.com/faisal-memon/spiffe-helper/commit/80513be8775579fadc65aabbe92ad3259a5b2654

azdagron commented 4 years ago

I've added comment to your commit with one solution.

Also, just a note, we're actively developing a v2 version of the go-spiffe library that should be ready in a few short weeks (hopefully sooner). We'll probably want to move to the v2 library when it comes out.

faisal-memon commented 4 years ago

Thanks for the feedback. Ill wait for the v2 library before continuing work on this.

azdagron commented 4 years ago

Cool. I appreciate you working on this, @faisal-memon!

blaggacao commented 4 years ago

Maybe out of scope: It would be nice to provide cli overrides which are passed to the cmdArgs.

In that way, when working with docker, I don't need an alternative helper.conf just to pass a debug flag around.

spiffe-helper -- -vvvv

faisal-memon commented 3 years ago

I was able to update this to use the v2 api. PR: https://github.com/spiffe/spiffe-helper/pull/25

faisal-memon commented 3 years ago

Any interest in this PR?

faisal-memon commented 1 year ago

Resolved via https://github.com/spiffe/spiffe-helper/pull/25