spiffe / spiffe-helper

The SPIFFE Helper is a tool that can be used to retrieve and manage SVIDs on behalf of a workload
Apache License 2.0
43 stars 40 forks source link

Mosquitto Example #76

Closed fdeantoni closed 1 year ago

fdeantoni commented 1 year ago

Added an example using Mosquitto broker.

faisal-memon commented 1 year ago

Thanks @fdeantoni for submitting this. Im not familiar with mosquitto, but i will review for other correctness.

fdeantoni commented 1 year ago

Thanks for the review @faisal-memon ! I have added some comments to a few of your recommendations. Let me know what you think. After that I will push the corrections...

faisal-memon commented 1 year ago

Thanks for the review @faisal-memon ! I have added some comments to a few of your recommendations. Let me know what you think. After that I will push the corrections...

@fdeantoni Put in my follow up replies

fdeantoni commented 1 year ago

Hi @faisal-memon, pushed the changes as suggested. Let me know if ok!