search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

add an auth token to gh api requests #272

Open peterj opened 1 year ago

peterj commented 1 year ago

This PR adds the Authorization header to the github API requests to minimize the chances of getting rate limited by GH.

Note that for this to work, someone needs to do the following:

Resolves #271

netlify[bot] commented 1 year ago

Deploy Preview for spiffe failed.

Name Link
Latest commit 4875ecfe3af8c57971ebb3133e5e8934365a7744
Latest deploy log https://app.netlify.com/sites/spiffe/deploys/6400ed1b53fe1f00083448e3
peterj commented 1 year ago

Adding the note here from Slack.

For the token, we'd need someone with admin permissions on the repo to create a fine-grained personal access token for the spiffe.io repo. The permission needed is under Repository permissions -> Contents

Screenshot 2023-02-16 at 10 34 45 AM
mchurichi commented 1 year ago

Hi @peterj, thanks for opening this PR!. For some reason I don't see the changes anymore, they seem to have been overwritten by the most recent force push.

Sorry for the delay on getting this merged, it looks good to me. We are just trying to get someone with admin access to review this, give a thumbs up and set the token. Would you mind republishing the changes?

peterj commented 1 year ago

I’ll repush and reopen. yeah, we were waiting for someone with admin access to create the Gh token.

On Fri, Feb 24, 2023 at 07:12 Maximiliano Churichi @.***> wrote:

Hi @peterj https://github.com/peterj, thanks for opening this PR!. For some reason I don't see the changes anymore, they seem to have been overwritten by the most recent force push.

Sorry for the delay on getting this merged, it looks good to me. We are just trying to get someone with admin access to review this, give a thumbs up and set the token. Would you mind republishing the changes?

— Reply to this email directly, view it on GitHub https://github.com/spiffe/spiffe.io/pull/272#issuecomment-1443826020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACURJ3EBCIBBJAM73GIFXEDWZDFVBANCNFSM6AAAAAAU37BHZQ . You are receiving this because you were mentioned.Message ID: @.***>